From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 537EB1F403 for ; Mon, 17 Oct 2022 17:51:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230131AbiJQRvG (ORCPT ); Mon, 17 Oct 2022 13:51:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231152AbiJQRut (ORCPT ); Mon, 17 Oct 2022 13:50:49 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9DB51DA79 for ; Mon, 17 Oct 2022 10:50:32 -0700 (PDT) Received: (qmail 27455 invoked by uid 109); 17 Oct 2022 17:50:13 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 17 Oct 2022 17:50:13 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 9137 invoked by uid 111); 17 Oct 2022 17:50:09 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 17 Oct 2022 13:50:09 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 17 Oct 2022 13:50:08 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , SZEDER =?utf-8?B?R8OhYm9y?= Subject: Re: [PATCH v3 00/11] cocci: make "incremental" possible + a ccache-like tool Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Oct 14, 2022 at 05:31:16PM +0200, Ævar Arnfjörð Bjarmason wrote: > The big change in this belated v3 is that we now run against a > concatenated version of all our *.cocci files. This is something I > discussed with Jeff King at Git Merge, after having confirmed the > viability of that approach on the cocci mailing list. Is that safe? The last time it was brought up on this list (AFAIK) was in: https://lore.kernel.org/git/alpine.DEB.2.20.1808030755350.2446@hadrien/ where Julia said: I'm surprised that the above cat command would work. Semantic patch rules have names, and Coccinelle will not be happy isf two rules have the same name. Some may also have variables declared in initializers, although perhaps the ones in the kernel don't do this. Causing these variables to be shared would not have a good effect. Putting everything together can also go counter to the optimizations that Coccinelle provides. [...] Maybe we don't do any of the things that could trigger problems in our spatch rules. But it's not clear to me what we're risking. Do you have a link for further discussion? -Peff