From: Jeff King <peff@peff.net>
To: William Blevins <wblevins001@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: Unexpected (bug-like) behavior in `git ls-remote` matching.
Date: Wed, 8 Feb 2023 11:30:03 -0500 [thread overview]
Message-ID: <Y+POCxHMzrZj2bwz@coredump.intra.peff.net> (raw)
In-Reply-To: <CALJHx12DetwZ=+aMEG6Ss4P3fMTeLN2styXuPw93C5N6yg98NA@mail.gmail.com>
On Wed, Feb 08, 2023 at 08:49:57AM -0500, William Blevins wrote:
> This still feels "weird" to me. Other pattern matching tools like grep
> and sed don't have exceptions to their behavior like this.
>
> Can you reference the unit tests that verifies this specific behavior?
See commit 631f0f8c4b (ls-remote: do not send ref prefixes for patterns,
2018-10-31), which also adds a test. However, it was just handling
existing behavior (which in fact confused another developer and caused a
bug which the commit was fixing!).
I think the tail-matching behavior is not what we would probably choose
today, but that is how it has behaved since 2005, and we are not going
to break backwards compatibility in a plumbing tool like ls-remote.
There's some discussion in this thread about adding a new option to do
prefix-matching, but I don't think any code was ever written:
https://lore.kernel.org/git/m2k12g7v5u.fsf@gmail.com/
Likewise, something more elaborate like full-path globbing or even
regex matching would be possible, but would need to be activated by an
option.
-Peff
next prev parent reply other threads:[~2023-02-08 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 23:03 Unexpected (bug-like) behavior in `git ls-remote` matching William Blevins
2023-02-08 7:20 ` Junio C Hamano
2023-02-08 13:49 ` William Blevins
2023-02-08 14:51 ` Philip Oakley
2023-02-08 16:30 ` Jeff King [this message]
2023-02-08 16:33 ` Jeff King
2023-02-08 17:46 ` Junio C Hamano
2023-02-08 17:40 ` Junio C Hamano
2023-02-09 13:15 ` Jeff King
2023-02-09 19:43 ` Junio C Hamano
2023-02-11 2:41 ` Jeff King
2023-02-11 2:44 ` [PATCH 1/2] doc/ls-remote: cosmetic cleanups for examples Jeff King
2023-02-11 2:44 ` [PATCH 2/2] doc/ls-remote: clarify pattern format Jeff King
2023-02-11 2:54 ` Junio C Hamano
2023-02-11 4:52 ` [PATCH v2 " Jeff King
2023-02-08 14:08 ` Unexpected (bug-like) behavior in `git ls-remote` matching Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+POCxHMzrZj2bwz@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wblevins001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).