git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, rsbecker@nexbridge.com
Subject: Re: [PATCH] test-genzeros: avoid raw write(2)
Date: Wed, 15 Feb 2023 23:34:56 -0500	[thread overview]
Message-ID: <Y+2ycMAkVd8rh50q@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqo7putj1t.fsf_-_@gitster.g>

On Wed, Feb 15, 2023 at 06:56:14PM -0800, Junio C Hamano wrote:

> This test helper feeds 256kB of data at once to a single invocation
> of the write(2) system call, which may be too much for some
> platforms.
> 
> Call our xwrite() wrapper that knows to honor MAX_IO_SIZE limit and
> cope with short writes due to EINTR instead, and die a bit more
> loudly by calling die_errno() when xwrite() indicates an error.

Thanks, this looks good to me.

>     I ended up avoiding write_or_die() primarily because there is
>     nothing "Git" about this helper, which is a poor-man's emulation
>     of "dd if=/dev/zero".  It felt a bit too much to pull cache.h in
>     as dependency for it.

I don't find it any more "Git" than xwrite() or die_errno(), really, but
I am quite happy with what you have here.

-Peff

  reply	other threads:[~2023-02-16  4:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 17:44 [Bug] Test 1450.91 Fails on NonStop rsbecker
2023-02-15 17:59 ` rsbecker
2023-02-15 18:02 ` Jeff King
2023-02-15 18:49   ` rsbecker
2023-02-15 19:10     ` Junio C Hamano
2023-02-15 19:41       ` rsbecker
2023-02-15 19:59       ` Jeff King
2023-02-16  1:45         ` Junio C Hamano
2023-02-16  2:56           ` [PATCH] test-genzeros: avoid raw write(2) Junio C Hamano
2023-02-16  4:34             ` Jeff King [this message]
2023-02-16 16:09               ` Junio C Hamano
2023-02-16 16:14                 ` rsbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+2ycMAkVd8rh50q@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).