git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/21] more -Wunused-parameter fixes
Date: Fri, 24 Feb 2023 01:34:21 -0500	[thread overview]
Message-ID: <Y/habYJxDRJQg/kJ@coredump.intra.peff.net> (raw)

I've been sitting on this series for a while, waiting for a moment when
I didn't have a backlog of other topics I ought to be reviewing. But it
seems like that never happens, so I thought I'd just send it. :) Nothing
urgent, of course, but this takes us a few steps closer to being able to
turn on -Wunused-parameter all the time.

I've tried to float the more interesting patches to the top. The later
ones are mostly "yep, this callback needs to marked with UNUSED".

-Peff

  [01/21]: ref-filter: drop unused atom parameter from get_worktree_path()
  [02/21]: ls-refs: drop config caching
  [03/21]: serve: use repository pointer to get config
  [04/21]: serve: mark unused parameters in virtual functions
  [05/21]: object-name: mark unused parameters in disambiguate callbacks
  [06/21]: http-backend: mark argc/argv unused
  [07/21]: http-backend: mark unused parameters in virtual functions
  [08/21]: ref-filter: mark unused callback parameters
  [09/21]: mark "pointless" data pointers in callbacks
  [10/21]: run-command: mark error routine parameters as unused
  [11/21]: mark unused parameters in signal handlers
  [12/21]: list-objects: mark unused callback parameters
  [13/21]: for_each_object: mark unused callback parameters
  [14/21]: prio-queue: mark unused parameters in comparison functions
  [15/21]: notes: mark unused callback parameters
  [16/21]: fetch-pack: mark unused parameter in callback function
  [17/21]: rewrite_parents(): mark unused callback parameter
  [18/21]: for_each_commit_graft(): mark unused callback parameter
  [19/21]: userformat_want_item(): mark unused parameter
  [20/21]: run_processes_parallel: mark unused callback parameters
  [21/21]: help: mark unused parameter in git_unknown_cmd_config()

 builtin/cat-file.c          |  8 ++---
 builtin/count-objects.c     |  6 ++--
 builtin/fast-import.c       |  2 +-
 builtin/fetch.c             |  6 ++--
 builtin/fsck.c              | 25 +++++++-------
 builtin/gc.c                | 14 ++++----
 builtin/log.c               |  2 +-
 builtin/notes.c             |  5 +--
 builtin/pack-objects.c      | 26 ++++++++-------
 builtin/prune.c             |  6 ++--
 builtin/repack.c            |  5 +--
 builtin/rev-list.c          | 13 ++++----
 builtin/submodule--helper.c |  4 +--
 bundle-uri.c                |  2 +-
 commit.c                    |  6 ++--
 daemon.c                    |  2 +-
 diagnose.c                  |  3 +-
 fetch-pack.c                |  2 +-
 help.c                      |  3 +-
 hook.c                      | 12 +++----
 http-backend.c              |  8 ++---
 line-log.c                  |  3 +-
 log-tree.c                  |  3 +-
 ls-refs.c                   | 36 ++++++++------------
 midx.c                      |  2 +-
 negotiator/skipping.c       |  2 +-
 notes.c                     | 11 ++++---
 object-file.c               |  3 +-
 object-name.c               | 14 ++++----
 pack-bitmap.c               |  6 ++--
 packfile.c                  |  4 +--
 path.c                      |  3 +-
 pretty.c                    |  3 +-
 progress.c                  |  2 +-
 reachable.c                 | 15 +++++----
 ref-filter.c                | 66 +++++++++++++++++++++++--------------
 revision.c                  |  6 ++--
 run-command.c               |  6 ++--
 serve.c                     | 12 +++----
 submodule.c                 |  4 +--
 t/helper/test-prio-queue.c  |  2 +-
 t/helper/test-run-command.c | 14 ++++----
 upload-pack.c               | 10 +++---
 43 files changed, 211 insertions(+), 176 deletions(-)


             reply	other threads:[~2023-02-24  6:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24  6:34 Jeff King [this message]
2023-02-24  6:34 ` [PATCH 01/21] ref-filter: drop unused atom parameter from get_worktree_path() Jeff King
2023-02-24 17:53   ` Junio C Hamano
2023-02-24  6:37 ` [PATCH 02/21] ls-refs: drop config caching Jeff King
2023-02-24  6:38 ` [PATCH 03/21] serve: use repository pointer to get config Jeff King
2023-02-24 17:59   ` Junio C Hamano
2023-02-24  6:38 ` [PATCH 04/21] serve: mark unused parameters in virtual functions Jeff King
2023-02-24  6:38 ` [PATCH 05/21] object-name: mark unused parameters in disambiguate callbacks Jeff King
2023-02-24  6:38 ` [PATCH 06/21] http-backend: mark argc/argv unused Jeff King
2023-02-24  6:38 ` [PATCH 07/21] http-backend: mark unused parameters in virtual functions Jeff King
2023-02-24  6:39 ` [PATCH 08/21] ref-filter: mark unused callback parameters Jeff King
2023-02-24  6:39 ` [PATCH 09/21] mark "pointless" data pointers in callbacks Jeff King
2023-02-24  6:39 ` [PATCH 10/21] run-command: mark error routine parameters as unused Jeff King
2023-02-24  6:39 ` [PATCH 11/21] mark unused parameters in signal handlers Jeff King
2023-02-24  6:39 ` [PATCH 12/21] list-objects: mark unused callback parameters Jeff King
2023-02-24  6:39 ` [PATCH 13/21] for_each_object: " Jeff King
2023-02-24  6:39 ` [PATCH 14/21] prio-queue: mark unused parameters in comparison functions Jeff King
2023-02-24  6:39 ` [PATCH 15/21] notes: mark unused callback parameters Jeff King
2023-02-24  6:39 ` [PATCH 16/21] fetch-pack: mark unused parameter in callback function Jeff King
2023-02-24  6:39 ` [PATCH 17/21] rewrite_parents(): mark unused callback parameter Jeff King
2023-02-24  6:39 ` [PATCH 18/21] for_each_commit_graft(): " Jeff King
2023-02-24  6:39 ` [PATCH 19/21] userformat_want_item(): mark unused parameter Jeff King
2023-02-24  6:39 ` [PATCH 20/21] run_processes_parallel: mark unused callback parameters Jeff King
2023-02-24  6:39 ` [PATCH 21/21] help: mark unused parameter in git_unknown_cmd_config() Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y/habYJxDRJQg/kJ@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).