From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 1654D1F626 for ; Fri, 24 Feb 2023 02:11:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229549AbjBXCLX (ORCPT ); Thu, 23 Feb 2023 21:11:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjBXCLV (ORCPT ); Thu, 23 Feb 2023 21:11:21 -0500 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92EDF48E23 for ; Thu, 23 Feb 2023 18:11:20 -0800 (PST) Received: (qmail 1857 invoked by uid 109); 24 Feb 2023 02:11:20 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 24 Feb 2023 02:11:20 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 28152 invoked by uid 111); 24 Feb 2023 02:11:19 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 23 Feb 2023 21:11:19 -0500 Authentication-Results: peff.net; auth=none Date: Thu, 23 Feb 2023 21:11:18 -0500 From: Jeff King To: Junio C Hamano Cc: git@vger.kernel.org Subject: Re: [PATCH 03/16] t5541: simplify and move "no empty path components" test Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Feb 23, 2023 at 03:36:45PM -0800, Junio C Hamano wrote: > > As a bonus, this also lets us drop the check for the v0 protocol (which > > is otherwise necessary since v2 makes multiple requests, and > > check_access_log insists on exactly matching the number of requests, > > even though we don't care about that here). > > Makes me wonder why we do not clear the log for each test, but OK. Yes, I think that is a better strategy than the current code, but IMHO these targeted greps are even better at showing what we really care about. After my series, there are only two calls to check_access_log left: - the one in t5541, from patch 2. This could be a grep, but since there is no v0/v2 confusion it was easy enough to leave it (and after my patch, it now is clearing and checking the activity of just one test) - one in t5561, which really does want to check the results after a ton of manual requests So I think the state after my series is OK, at least from a maintenance perspective. -Peff