From: Jeff King <peff@peff.net>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] cmake: determine list of extra built-ins dynamically
Date: Fri, 4 Dec 2020 16:11:38 -0500 [thread overview]
Message-ID: <X8qmClPjwYWIoExP@coredump.intra.peff.net> (raw)
In-Reply-To: <pull.807.git.1607110436367.gitgitgadget@gmail.com>
On Fri, Dec 04, 2020 at 07:33:56PM +0000, Johannes Schindelin via GitGitGadget wrote:
> In 0a21d0e08902 (Makefile: mark git-maintenance as a builtin,
> 2020-12-01), we marked git-maintenance as a builtin in the Makefile, but
> forgot to do the same in `CMakeLists.txt`.
Oof, right.
> Rather than always play catch-up and adjust `git_builtin_extra`
> manually, use the `BUILT_INS` definitions in the Makefile as
> authoritative source and generate `git_builtin_extra` dynamically.
Yay. This is exactly how I'd hoped things would work or the cmake file
in general. I don't mind following micro-formats within our Makefile to
keep things easier for the cmake parsing side.
> contrib/buildsystems/CMakeLists.txt | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
The implementation looks plausibly correct to me (bearing in mind that
I've never written cmake).
-Peff
next prev parent reply other threads:[~2020-12-04 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 19:33 [PATCH] cmake: determine list of extra built-ins dynamically Johannes Schindelin via GitGitGadget
2020-12-04 20:10 ` Junio C Hamano
2020-12-04 22:41 ` Johannes Schindelin
2020-12-04 21:11 ` Jeff King [this message]
2020-12-04 22:44 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8qmClPjwYWIoExP@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).