From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, emilyshaffer@google.com
Subject: Re: [PATCH v2] builtin/bugreport.c: use thread-safe localtime_r()
Date: Tue, 1 Dec 2020 20:57:25 -0500 [thread overview]
Message-ID: <X8b0he9VVI5s1log@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqlfehqt4n.fsf@gitster.c.googlers.com>
On Tue, Dec 01, 2020 at 10:27:20AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > We might also want to do this on top:
> >
> > -- >8 --
> > Subject: [PATCH] banned.h: mark non-reentrant gmtime, etc as banned
>
> I see the patch does more than what subject describes.
>
> I am not opposed to banning ctime_r() and asctime_r(), but I do not
> want to see our future readers wonder why they are banned by the
> commit whose title clearly states that we refuse non-reentrant ones
> in our codebase.
Well, not more than the overall commit message describes. :)
But yeah, the split in what you re-sent is just fine with me. Thanks for
saving a round-trip. I see you already fixed up the typo in the second
one pointed out by Eric, but I think there is another:
s/stftime/strftime/
-Peff
next prev parent reply other threads:[~2020-12-02 1:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 23:06 [PATCH] builtin/bugreport.c: use thread-safe localtime_r() Taylor Blau
2020-12-01 0:30 ` [PATCH v2] " Taylor Blau
2020-12-01 2:27 ` Jeff King
2020-12-01 3:15 ` Eric Sunshine
2020-12-01 18:27 ` Junio C Hamano
2020-12-01 18:34 ` Taylor Blau
2020-12-01 21:11 ` [PATCH v2 1/2] banned.h: mark non-reentrant gmtime, etc as banned Junio C Hamano
2020-12-01 21:11 ` [PATCH v2 2/2] banned.h: mark ctime_r() and asctime_r() " Junio C Hamano
2020-12-01 21:16 ` Eric Sunshine
2020-12-01 22:07 ` Junio C Hamano
2020-12-01 22:22 ` Taylor Blau
2020-12-06 14:56 ` [PATCH v2 1/2] banned.h: mark non-reentrant gmtime, etc " SZEDER Gábor
2020-12-02 1:57 ` Jeff King [this message]
2020-12-01 0:31 ` [PATCH] builtin/bugreport.c: use thread-safe localtime_r() Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8b0he9VVI5s1log@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).