From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 296B71F86C for ; Tue, 1 Dec 2020 10:30:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729829AbgLAK3Y (ORCPT ); Tue, 1 Dec 2020 05:29:24 -0500 Received: from cloud.peff.net ([104.130.231.41]:46966 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727055AbgLAK3Y (ORCPT ); Tue, 1 Dec 2020 05:29:24 -0500 Received: (qmail 25513 invoked by uid 109); 1 Dec 2020 10:28:43 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 01 Dec 2020 10:28:43 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 24840 invoked by uid 111); 1 Dec 2020 10:28:43 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 01 Dec 2020 05:28:43 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 1 Dec 2020 05:28:43 -0500 From: Jeff King To: Johannes Schindelin via GitGitGadget Cc: git@vger.kernel.org, Han-Wen Nienhuys , Han-Wen Nienhuys , Johannes Schindelin Subject: Re: [PATCH 6/6] fixup! reftable: rest of library Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Nov 28, 2020 at 06:44:38AM +0000, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > The stack_test hard-codes `/tmp/`. That is a particular problem on > Windows where the temp directory is never at that location. > > Let's not do that, but instead use `TMPDIR` as we do in similar > scenarios in the rest of Git's source code. Yeah, I noticed this, as well. This seems like a good band-aid, but it would probably be nice if the test tool was able to write into a specified directory (or even just the current directory). I don't see it being invoked anywhere, but presumably if we were to add support to our test suite, we'd have a script which invokes it within a scratch directory. -Peff