From: Jeff King <email@example.com> To: Junio C Hamano <firstname.lastname@example.org> Cc: "René Scharfe" <email@example.com>, 唐宇奕 <firstname.lastname@example.org>, email@example.com Subject: Re: Bug report: orphaned pack-objects after killing upload-pack on [ Date: Tue, 24 Nov 2020 04:11:05 -0500 [thread overview] Message-ID: <X7zOKbzR9gwJHMbJ@coredump.intra.peff.net> (raw) In-Reply-To: <firstname.lastname@example.org> On Sat, Nov 21, 2020 at 01:54:17PM -0800, Junio C Hamano wrote: > > I wrote this patch ages ago, and it is still sitting close to the bottom > > (if not the bottom) of my todo stack, waiting to be investigated. ;) > > Sounds sensible. > > > -- >8 -- > > Subject: [PATCH] send-pack: kill pack-objects helper on signal or exit Looks like you picked up this patch on a topic branch I was thinking of polishing it further with a test, but I can't think of a good way to do one that would not be horribly racy. I even tried to think of a racy test I could run manually (e.g., pushing and killing in a loop) but even that is tough (even with the patch, it's racy whether the push will succeed or not, depending on exactly when you kill the parent, so there's no automatic way to distinguish the improved cases). So I think it is still a good idea to do, and what I wrote earlier is as good a we can do. René, do you want to wrap up your similar patch for the fetch side? -Peff
next prev parent reply other threads:[~2020-11-24 9:12 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-19 8:18 唐宇奕 2020-11-20 18:52 ` Bug report: orphaned pack-objects after killing upload-pack on [was: (no subject)] René Scharfe 2020-11-21 0:29 ` Jeff King 2020-11-21 21:54 ` Bug report: orphaned pack-objects after killing upload-pack on [ Junio C Hamano 2020-11-24 3:21 ` 唐宇奕 2020-11-24 9:11 ` Jeff King [this message] 2020-11-25 21:42 ` Junio C Hamano 2020-11-26 0:53 ` Jeff King 2020-11-26 1:04 ` Junio C Hamano 2020-11-26 20:04 ` René Scharfe 2020-11-27 4:17 ` Jeff King 2020-11-27 20:43 ` René Scharfe 2020-11-28 6:30 ` Jeff King 2020-12-01 12:15 ` Jeff King 2020-12-02 11:45 ` René Scharfe 2020-12-02 22:14 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X7zOKbzR9gwJHMbJ@coredump.intra.peff.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Bug report: orphaned pack-objects after killing upload-pack on [' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).