From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 4E8051F86C for ; Thu, 26 Nov 2020 07:39:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730641AbgKZHhz (ORCPT ); Thu, 26 Nov 2020 02:37:55 -0500 Received: from cloud.peff.net ([104.130.231.41]:43470 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729906AbgKZHhz (ORCPT ); Thu, 26 Nov 2020 02:37:55 -0500 Received: (qmail 14932 invoked by uid 109); 26 Nov 2020 07:37:55 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 26 Nov 2020 07:37:55 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 14434 invoked by uid 111); 26 Nov 2020 07:37:54 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 26 Nov 2020 02:37:54 -0500 Authentication-Results: peff.net; auth=none Date: Thu, 26 Nov 2020 02:37:54 -0500 From: Jeff King To: =?utf-8?B?U2ltw6Nv?= Afonso Cc: git@vger.kernel.org, gitster@pobox.com Subject: Re: [PATCH v3] crendential-store: use timeout when locking file Message-ID: References: <20201125183123.47praa6hcgrgrib4@safonso-t430> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201125183123.47praa6hcgrgrib4@safonso-t430> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Nov 25, 2020 at 06:31:23PM +0000, Simão Afonso wrote: > When holding the lock for rewriting the credential file, use a timeout > to avoid race conditions when the credentials file needs to be updated > in parallel. > > An example would be doing `fetch --all` on a repository with several > remotes that need credentials, using parallel fetching. > > The timeout can be configured using "credentialStore.lockTimeoutMS", > defaulting to 1 second. > > Signed-off-by: Simão Afonso > --- > > lockTimeoutMS sounds like the consensual name, implemented. Thanks, this version looks good to me. -Peff