From: Jeff King <peff@peff.net>
To: "Simão Afonso" <simao.afonso@powertools-tech.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v3] crendential-store: use timeout when locking file
Date: Thu, 26 Nov 2020 02:37:54 -0500 [thread overview]
Message-ID: <X79bUrreRkpiiorU@coredump.intra.peff.net> (raw)
In-Reply-To: <20201125183123.47praa6hcgrgrib4@safonso-t430>
On Wed, Nov 25, 2020 at 06:31:23PM +0000, Simão Afonso wrote:
> When holding the lock for rewriting the credential file, use a timeout
> to avoid race conditions when the credentials file needs to be updated
> in parallel.
>
> An example would be doing `fetch --all` on a repository with several
> remotes that need credentials, using parallel fetching.
>
> The timeout can be configured using "credentialStore.lockTimeoutMS",
> defaulting to 1 second.
>
> Signed-off-by: Simão Afonso <simao.afonso@powertools-tech.com>
> ---
>
> lockTimeoutMS sounds like the consensual name, implemented.
Thanks, this version looks good to me.
-Peff
prev parent reply other threads:[~2020-11-26 7:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 18:07 [PATCH] credential-store: use timeout when locking file Simão Afonso
2020-10-30 19:49 ` Junio C Hamano
2020-11-24 19:32 ` [PATCH v2] crendential-store: " Simão Afonso
2020-11-24 22:08 ` Junio C Hamano
2020-11-25 9:37 ` Jeff King
2020-11-25 18:31 ` [PATCH v3] " Simão Afonso
2020-11-26 7:37 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X79bUrreRkpiiorU@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=simao.afonso@powertools-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).