From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id A01231F4B4 for ; Tue, 12 Jan 2021 08:53:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730487AbhALIwV (ORCPT ); Tue, 12 Jan 2021 03:52:21 -0500 Received: from cloud.peff.net ([104.130.231.41]:53054 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726890AbhALIwV (ORCPT ); Tue, 12 Jan 2021 03:52:21 -0500 Received: (qmail 6102 invoked by uid 109); 12 Jan 2021 08:51:40 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 12 Jan 2021 08:51:40 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 10811 invoked by uid 111); 12 Jan 2021 08:51:42 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 12 Jan 2021 03:51:42 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 12 Jan 2021 03:51:40 -0500 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, jrnieder@gmail.com Subject: Re: [PATCH 05/20] check_object(): convert to new revindex API Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jan 08, 2021 at 01:17:00PM -0500, Taylor Blau wrote: > Replace direct accesses to the revindex with calls to > 'offset_to_pack_pos()' and 'pack_pos_to_index()'. > > Since this caller already had some error checking (it can jump to the > 'give_up' label if it encounters an error), we can easily check whether > or not the provided offset points to an object in the given pack. This > error checking existed prior to this patch, too, since the caller checks > whether the return value from 'find_pack_revindex()' was NULL or not. Yay. Happy again to see things getting more robust. -Peff