From: Jiamu Sun <39@barroit.sh>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jiamu Sun <39@barroit.sh>
Subject: [PATCH 0/5] parseopt: add subcommand autocorrection
Date: Sun, 8 Mar 2026 21:17:20 +0900 [thread overview]
Message-ID: <SY0P300MB08019805A8304105FA805EB1CE78A@SY0P300MB0801.AUSP300.PROD.OUTLOOK.COM> (raw)
Git currently provides auto-correction for builtins and aliases, but
lacks this functionality for subcommands parsed via the parse-options
API. Subcommands are also commands, and typos will occur, too. Like:
git remote add-rul
So, this series introduces subcommand auto-correction.
Currently, builtins with mandatory subcommands enable autocorrection by
default. However, those using PARSE_OPT_SUBCOMMAND_OPTIONAL skip it to
avoid treating valid unknown arguments as mistyped subcommands.
This series adds PARSE_OPT_SUBCOMMAND_AUTOCORR, allowing commands with
optional subcommands to explicitly opt in to autocorrection. It then
enables this flag for git-remote and git-notes.
Additionally, it extracts the existing autocorrection logic from help.c
so subcommand handling can reuse the same config parsing and
prompt/delay logic.
Jiamu Sun (5):
parseopt: extract subcommand handling from parse_options_step()
help: refactor command autocorrection handling
parseopt: autocorrect mistyped subcommands
parseopt: enable subcommand autocorrect for remote and notes
help: add tests for subcommand autocorrection
Makefile | 1 +
autocorrect.c | 92 +++++++++++++++++++
autocorrect.h | 23 +++++
builtin/notes.c | 10 +-
builtin/remote.c | 12 +--
help.c | 106 ++++-----------------
parse-options.c | 147 +++++++++++++++++++++++-------
parse-options.h | 1 +
t/t9004-autocorrect-subcommand.sh | 49 ++++++++++
9 files changed, 306 insertions(+), 135 deletions(-)
create mode 100644 autocorrect.c
create mode 100644 autocorrect.h
create mode 100755 t/t9004-autocorrect-subcommand.sh
base-commit: 795c338de725e13bd361214c6b768019fc45a2c1
--
2.53.0
next reply other threads:[~2026-03-08 12:18 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 12:17 Jiamu Sun [this message]
2026-03-08 12:17 ` [PATCH 1/5] parseopt: extract subcommand handling from parse_options_step() Jiamu Sun
2026-03-08 23:40 ` Junio C Hamano
2026-03-09 1:56 ` Jiamu Sun
2026-03-08 12:17 ` [PATCH 2/5] help: refactor command autocorrection handling Jiamu Sun
2026-03-08 23:52 ` Junio C Hamano
2026-03-09 2:06 ` Jiamu Sun
2026-03-08 12:17 ` [PATCH 3/5] parseopt: autocorrect mistyped subcommands Jiamu Sun
2026-03-09 0:04 ` Junio C Hamano
2026-03-09 2:11 ` Jiamu Sun
2026-03-08 12:17 ` [PATCH 4/5] parseopt: enable subcommand autocorrect for remote and notes Jiamu Sun
2026-03-08 12:17 ` [PATCH 5/5] help: add tests for subcommand autocorrection Jiamu Sun
2026-03-11 17:01 ` Aaron Plattner
2026-03-11 22:45 ` Jiamu Sun
2026-03-12 13:35 ` Junio C Hamano
2026-03-08 20:11 ` [PATCH 0/5] parseopt: add " Junio C Hamano
2026-03-08 22:07 ` Jiamu Sun
2026-03-08 23:16 ` [PATCH v2 " Jiamu Sun
2026-03-08 23:16 ` [PATCH v2 1/5] parseopt: extract subcommand handling from parse_options_step() Jiamu Sun
2026-03-08 23:16 ` [PATCH v2 2/5] help: refactor command autocorrection handling Jiamu Sun
2026-03-08 23:16 ` [PATCH v2 3/5] parseopt: autocorrect mistyped subcommands Jiamu Sun
2026-03-08 23:16 ` [PATCH v2 4/5] parseopt: enable subcommand autocorrect for remote and notes Jiamu Sun
2026-03-08 23:16 ` [PATCH v2 5/5] help: add tests for subcommand autocorrection Jiamu Sun
2026-03-10 11:40 ` [PATCH v3 0/8] parseopt: add " Jiamu Sun
2026-03-10 11:41 ` [PATCH v3 1/8] parseopt: extract subcommand handling from parse_options_step() Jiamu Sun
2026-03-10 12:46 ` Karthik Nayak
2026-03-11 1:49 ` Jiamu Sun
2026-03-11 4:20 ` Junio C Hamano
2026-03-11 4:20 ` Junio C Hamano
2026-03-11 6:12 ` Jiamu Sun
2026-03-10 11:41 ` [PATCH v3 2/8] help: make autocorrect handling reusable Jiamu Sun
2026-03-10 12:52 ` Karthik Nayak
2026-03-10 20:10 ` Junio C Hamano
2026-03-11 2:05 ` Jiamu Sun
2026-03-11 1:58 ` Jiamu Sun
2026-03-10 11:41 ` [PATCH v3 3/8] help: move tty check for autocorrection to autocorrect.c Jiamu Sun
2026-03-10 14:06 ` Karthik Nayak
2026-03-11 2:16 ` Jiamu Sun
2026-03-12 0:10 ` Jiamu Sun
2026-03-10 11:41 ` [PATCH v3 4/8] autocorrect: rename AUTOCORRECT_SHOW to AUTOCORRECT_HINTONLY Jiamu Sun
2026-03-10 14:08 ` Karthik Nayak
2026-03-11 2:46 ` Jiamu Sun
2026-03-10 11:41 ` [PATCH v3 5/8] autocorrect: provide config resolution API Jiamu Sun
2026-03-10 14:15 ` Karthik Nayak
2026-03-10 11:41 ` [PATCH v3 6/8] parseopt: autocorrect mistyped subcommands Jiamu Sun
2026-03-10 20:16 ` Junio C Hamano
2026-03-11 2:48 ` Jiamu Sun
2026-03-11 23:26 ` Jiamu Sun
2026-03-12 2:38 ` Junio C Hamano
2026-03-12 4:53 ` Jiamu Sun
2026-03-10 11:41 ` [PATCH v3 7/8] parseopt: enable subcommand autocorrection for git-remote and git-notes Jiamu Sun
2026-03-10 11:41 ` [PATCH v3 8/8] help: add tests for subcommand autocorrection Jiamu Sun
2026-03-11 4:23 ` Junio C Hamano
2026-03-11 6:10 ` Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 00/10] parseopt: add " Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 01/10] parseopt: extract subcommand handling from parse_options_step() Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 02/10] help: make autocorrect handling reusable Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 03/10] help: move tty check for autocorrection to autocorrect.c Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 04/10] autocorrect: use mode and delay instead of magic numbers Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 05/10] autocorrect: rename AUTOCORRECT_SHOW to AUTOCORRECT_HINT Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 06/10] autocorrect: provide config resolution API Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 07/10] parseopt: autocorrect mistyped subcommands Jiamu Sun
2026-03-16 19:41 ` Junio C Hamano
2026-03-17 3:21 ` Jiamu Sun
2026-04-15 17:55 ` Junio C Hamano
2026-04-16 2:24 ` Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 08/10] parseopt: enable subcommand autocorrection for git-remote and git-notes Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 09/10] parseopt: add tests for subcommand autocorrection Jiamu Sun
2026-03-16 15:36 ` [PATCH v4 10/10] doc: document autocorrect API Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 00/10] parseopt: add subcommand autocorrection Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 01/10] parseopt: extract subcommand handling from parse_options_step() Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 02/10] help: make autocorrect handling reusable Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 03/10] help: move tty check for autocorrection to autocorrect.c Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 04/10] autocorrect: use mode and delay instead of magic numbers Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 05/10] autocorrect: rename AUTOCORRECT_SHOW to AUTOCORRECT_HINT Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 06/10] autocorrect: provide config resolution API Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 07/10] parseopt: autocorrect mistyped subcommands Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 08/10] parseopt: enable subcommand autocorrection for git-remote and git-notes Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 09/10] parseopt: add tests for subcommand autocorrection Jiamu Sun
2026-04-22 12:18 ` [PATCH v5 10/10] doc: document autocorrect API Jiamu Sun
2026-04-23 0:08 ` [PATCH v5 00/10] parseopt: add subcommand autocorrection Junio C Hamano
2026-04-23 1:14 ` Jiamu Sun
2026-04-23 1:37 ` [PATCH v6 " Jiamu Sun
2026-04-23 1:37 ` [PATCH v6 01/10] parseopt: extract subcommand handling from parse_options_step() Jiamu Sun
2026-04-23 1:37 ` [PATCH v6 02/10] help: make autocorrect handling reusable Jiamu Sun
2026-04-23 1:37 ` [PATCH v6 03/10] help: move tty check for autocorrection to autocorrect.c Jiamu Sun
2026-04-23 1:37 ` [PATCH v6 04/10] autocorrect: use mode and delay instead of magic numbers Jiamu Sun
2026-04-23 1:37 ` [PATCH v6 05/10] autocorrect: rename AUTOCORRECT_SHOW to AUTOCORRECT_HINT Jiamu Sun
2026-04-23 1:37 ` [PATCH v6 06/10] autocorrect: provide config resolution API Jiamu Sun
2026-04-23 1:37 ` [PATCH v6 07/10] parseopt: autocorrect mistyped subcommands Jiamu Sun
2026-04-23 1:37 ` [PATCH v6 08/10] parseopt: enable subcommand autocorrection for git-remote and git-notes Jiamu Sun
2026-04-23 1:37 ` [PATCH v6 09/10] parseopt: add tests for subcommand autocorrection Jiamu Sun
2026-04-23 1:38 ` [PATCH v6 10/10] doc: document autocorrect API Jiamu Sun
2026-05-11 3:03 ` [PATCH v6 00/10] parseopt: add subcommand autocorrection Junio C Hamano
2026-05-15 14:34 ` Jiamu Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SY0P300MB08019805A8304105FA805EB1CE78A@SY0P300MB0801.AUSP300.PROD.OUTLOOK.COM \
--to=39@barroit.sh \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).