From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 6/6] DWIM "git add remote ..."
Date: Wed, 5 Dec 2007 19:47:44 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0712051946350.27959@racer.site> (raw)
In-Reply-To: <alpine.LFD.0.9999.0712051129280.13796@woody.linux-foundation.org>
Hi,
On Wed, 5 Dec 2007, Linus Torvalds wrote:
> On Wed, 5 Dec 2007, Johannes Schindelin wrote:
> >
> > It is wrong to divert to "git remote add" when you typed the (more
> > English) "git add remote". But is it also pretty convenient.
>
> Please don't do cute things like this. Suddenly "git add remote" has two
> different meanings depending on whether you have a file called "remote"
> or not. That is *not* ok.
>
> Not to mention the fact that your patch is also a horrible piece of
> bug-infested shit, to put it less-than-politely. Namely, you now broke
> "git add remote" when "remote" is a symbolic link pointing to
> hyperspace.
>
> But even if you fix that bug, it only goes to show just how misguided
> things like these are. It's a *lot* more important to make sense and not
> have surprising special cases, than to try to make git command lines act
> as if they were free-form English.
Hehe. You're right, of course. But I could not resist showing off that
patch which I wrote after I mixed up the command line of "remote add" for
the 926th time.
Ciao,
Dscho
prev parent reply other threads:[~2007-12-05 19:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 19:00 [PATCH 0/6] builtin-remote Johannes Schindelin
2007-12-05 19:00 ` (unknown) Johannes Schindelin
2007-12-05 19:01 ` your mail Johannes Schindelin
2007-12-05 19:05 ` [PATCH 1/6] path-list: add functions to work with unsorted lists Johannes Schindelin
2007-12-05 19:01 ` [PATCH 2/6] parseopt: add flag to stop on first non option Johannes Schindelin
2007-12-05 19:02 ` [PATCH 3/6] Test "git remote show" and "git remote prune" Johannes Schindelin
2007-12-05 21:59 ` René Scharfe
2007-12-05 22:38 ` Johannes Schindelin
2007-12-05 19:02 ` [PATCH 4/6] Make git-remote a builtin Johannes Schindelin
2007-12-05 21:40 ` [PATCH 7/6] builtin-remote: guard remote->url accesses by remote->url_nr check Johannes Schindelin
2007-12-05 19:02 ` [PATCH 5/6] builtin-remote: prune remotes correctly that were added with --mirror Johannes Schindelin
2007-12-05 19:03 ` [PATCH 6/6] DWIM "git add remote ..." Johannes Schindelin
2007-12-05 19:34 ` Linus Torvalds
2007-12-05 19:47 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0712051946350.27959@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).