From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: "Pierre Habouzit" <madcoder@debian.org>,
"René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
git@vger.kernel.org, "Nicolas Pitre" <nico@cam.org>
Subject: Re: [PATCH 07/25] parse-options: make some arguments optional, add callbacks.
Date: Wed, 17 Oct 2007 19:00:35 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710171900060.25221@racer.site> (raw)
In-Reply-To: <20071017044405.GV13801@spearce.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1102 bytes --]
Hi,
On Wed, 17 Oct 2007, Shawn O. Pearce wrote:
> Pierre Habouzit <madcoder@debian.org> wrote:
> > On Tue, Oct 16, 2007 at 04:38:36PM +0000, René Scharfe wrote:
> > > Pierre Habouzit schrieb:
> > > > This bit is to allow to aggregate options with arguments together when
> > > > the argument is numeric.
> > > >
> > > > +#if 0
> > > > + /* can be used to understand -A1B1 like -A1 -B1 */
> > > > + if (flag & OPT_SHORT && opt->opt && isdigit(*opt->opt)) {
> > > > + *(int *)opt->value = strtol(opt->opt, (char **)&opt->opt, 10);
> > > > + return 0;
> > > > + }
> > > > +#endif
> > >
> > > I don't like it, it complicates number options with unit suffixes (e.g.
> > > --windows-memory of git-pack-objects).
> ...
> > This is a very strong argument _against_ this chunk IMO.
>
> Since everyone (including myself)
... except for me ...
> is apparently strongly against this hunk I removed it when I
> cherry-picked this series from Pierre into my tree. The series will be
> in my pu tonight, but minus this hunk.
I can live without this hunk.
Ciao,
Dscho
next prev parent reply other threads:[~2007-10-17 18:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 8:16 [parse-options] proposal for merge, take 1 Pierre Habouzit
2007-10-16 8:20 ` Pierre Habouzit
2007-10-16 8:43 ` Pierre Habouzit
[not found] ` <1192523998-19474-1-git-send-email-madcoder@debian.org>
[not found] ` <1192523998-19474-2-git-send-email-madcoder@debian.org>
[not found] ` <1192523998-19474-3-git-send-email-madcoder@debian.org>
[not found] ` <1192523998-19474-4-git-send-email-madcoder@debian.org>
[not found] ` <1192523998-19474-5-git-send-email-madcoder@debian.org>
[not found] ` <1192523998-19474-6-git-send-email-madcoder@debian.org>
[not found] ` <1192523998-19474-7-git-send-email-madcoder@debian.org>
2007-10-16 8:45 ` [PATCH 07/25] parse-options: make some arguments optional, add callbacks Pierre Habouzit
2007-10-16 13:18 ` Johannes Schindelin
2007-10-16 16:38 ` René Scharfe
2007-10-16 16:44 ` Johannes Schindelin
2007-10-16 16:53 ` Pierre Habouzit
2007-10-16 17:21 ` Nicolas Pitre
2007-10-16 17:04 ` René Scharfe
2007-10-16 16:44 ` Nicolas Pitre
2007-10-16 16:50 ` Pierre Habouzit
2007-10-17 4:44 ` Shawn O. Pearce
2007-10-17 18:00 ` Johannes Schindelin [this message]
[not found] ` <1192523998-19474-8-git-send-email-madcoder@debian.org>
[not found] ` <1192523998-19474-9-git-send-email-madcoder@debian.org>
2007-10-16 8:55 ` [PATCH 09/25] Port builtin-add.c to use the new option parser Michael Witten
2007-10-16 9:36 ` Michael Witten
2007-10-16 13:17 ` Johannes Schindelin
2007-10-16 15:36 ` Michael Witten
2007-10-16 16:55 ` Pierre Habouzit
2007-10-16 17:56 ` [PATCH 04/25] Rework make_usage to print the usage message immediately Alex Riesen
2007-10-16 22:15 ` Pierre Habouzit
2007-10-17 19:06 ` Alex Riesen
[not found] ` <1192523721-18985-1-git-send-email-madcoder@debian.org>
2007-10-17 7:24 ` [PATCH 01/25] Add a simple option parser Shawn O. Pearce
2007-10-17 7:52 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710171900060.25221@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=nico@cam.org \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).