From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Matt Kraai <kraai@ftbfs.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Move convert-objects to contrib.
Date: Tue, 25 Sep 2007 11:01:58 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0709251100560.28395@racer.site> (raw)
In-Reply-To: <1190690061-6720-1-git-send-email-kraai@ftbfs.org>
Hi,
the commit message looks a little bit empty to me. I'd at least mention
why convert-objects was needed, why it is no longer needed, and that
Linus, the original author, is okay with it.
And you might want to use the "-M" flag to format-patch next time (detect
renames).
Ciao,
Dscho
next prev parent reply other threads:[~2007-09-25 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 3:14 [PATCH] Move convert-objects to contrib Matt Kraai
2007-09-25 10:01 ` Johannes Schindelin [this message]
2007-09-25 14:04 ` Matt Kraai
2007-09-25 14:06 ` Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2007-09-25 14:03 Matt Kraai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709251100560.28395@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=kraai@ftbfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).