git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: pierre.dumuid@adelaide.edu.au
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Button added to performs a GUI diff (inline)
Date: Sun, 9 Sep 2007 00:34:35 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0709090031260.28586@racer.site> (raw)
In-Reply-To: <200709081231.26894.pmdumuid@pezdell>

Hi,

On Sat, 8 Sep 2007, Pierre Marc Dumuid wrote:

> From bd43cca7aa88282455b6bbe6e2f9d8134da1029c Mon Sep 17 00:00:00 2001
> From: Pierre Marc Dumuid <pierre.dumuid@adelaide.edu.au>
> Date: Sat, 8 Sep 2007 00:32:10 +0930
> Subject: [PATCH] Button added to performs a GUI diff

Almost!  Just make sure that you are sending this patch with the correct 
Sender and put the Subject: line as subject of your mail.

And then describe in more detail what the patch does (This commit adds a 
button to gitk to easily look at diffs between a commit and its first 
parent.  It uses the GUI tool selected in merge.tool to visualize the 
diff, erroring out if none was specified.)

> +    if {[catch {exec git cat-file -p $sha1string^:$fname > .gitk_diffolder} err] 
> +	|| [catch {exec git cat-file -p $sha1string:$fname > .gitk_diffnewer} err]} {
> +	error_popup "Invalid file selected for comparison"
> +	return
> +    }

I think I found a solution for removing the temporary files: man n after.

Ciao,
Dscho

      reply	other threads:[~2007-09-09  8:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-08  3:01 [PATCH] Button added to performs a GUI diff (inline) Unknown, Pierre Marc Dumuid
2007-09-08 23:34 ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0709090031260.28586@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=pierre.dumuid@adelaide.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).