From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: People unaware of the importance of "git gc"? Date: Thu, 6 Sep 2007 16:54:56 +0100 (BST) Message-ID: References: <20070905074206.GA31750@artemis.corp> <87odgh0zn6.fsf@hades.wkstn.nix> <46DEF1FA.4050500@midwinter.com> <877in50y7p.fsf@hades.wkstn.nix> <7vr6lcj2zi.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Nicolas Pitre , Nix , Steven Grimm , Linus Torvalds , Git Mailing List To: Junio C Hamano X-From: git-owner@vger.kernel.org Thu Sep 06 17:55:33 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1ITJhR-0008Aj-AU for gcvg-git@gmane.org; Thu, 06 Sep 2007 17:55:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755037AbXIFPzN (ORCPT ); Thu, 6 Sep 2007 11:55:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755094AbXIFPzN (ORCPT ); Thu, 6 Sep 2007 11:55:13 -0400 Received: from mail.gmx.net ([213.165.64.20]:42411 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755037AbXIFPzL (ORCPT ); Thu, 6 Sep 2007 11:55:11 -0400 Received: (qmail invoked by alias); 06 Sep 2007 15:55:10 -0000 Received: from unknown (EHLO [138.251.11.74]) [138.251.11.74] by mail.gmx.net (mp054) with SMTP; 06 Sep 2007 17:55:10 +0200 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX199/yxc1dZ9Yysi7Keiq6BKEz3mY6liTtWvd8jBmG eIw4yanyyKDjIq X-X-Sender: gene099@racer.site In-Reply-To: <7vr6lcj2zi.fsf@gitster.siamese.dyndns.org> X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Wed, 5 Sep 2007, Junio C Hamano wrote: > @@ -20,6 +20,7 @@ static const char builtin_gc_usage[] = "git-gc [--prune] [--aggressive]"; > > static int pack_refs = 1; > static int aggressive_window = -1; > +static int gc_auto_threshold = 6700; Please don't do that. When you share objects with another git directory, git-gc --auto can get rid of the objects when some objects go away in the referenced repository. So we need _at least_ check gc.auto not being set in the repo when "git clone --share"ing it (and fail otherwise). My preferred way would be to set it in "git init" so that existing setups are not affected, and put some big red message on top of the next release notes that people might want to set gc.auto in their existing setups. Ciao, Dscho