* [PATCH] verify-tag: also grok CR/LFs in the tag signature
@ 2007-09-03 16:51 Johannes Schindelin
0 siblings, 0 replies; only message in thread
From: Johannes Schindelin @ 2007-09-03 16:51 UTC (permalink / raw)
To: git, gitster
On some people's favorite platform, gpg outputs signatures
with CR/LF line endings. So verify-tag has to play nice with
them.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
I just pushed a fix to 4msysgit.git which prevents the generation
of such tag signatures, but it's always better to be a little more
graceful.
Note that the match less strict than before, but if you really
have to start a line in a signed tag with that magic BEGIN
PGP SIGNATURE string, you cannot be helped anyway.
builtin-verify-tag.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-verify-tag.c b/builtin-verify-tag.c
index 5c1314d..8cfefcf 100644
--- a/builtin-verify-tag.c
+++ b/builtin-verify-tag.c
@@ -35,7 +35,7 @@ static int run_gpg_verify(const char *buf, unsigned long size, int verbose)
/* find the length without signature */
len = 0;
- while (len < size && prefixcmp(buf + len, PGP_SIGNATURE "\n")) {
+ while (len < size && prefixcmp(buf + len, PGP_SIGNATURE)) {
eol = memchr(buf + len, '\n', size - len);
len += eol ? eol - (buf + len) + 1 : size - len;
}
--
1.5.3.2.g46909
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-09-03 16:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-03 16:51 [PATCH] verify-tag: also grok CR/LFs in the tag signature Johannes Schindelin
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).