From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: skimo@liacs.nl
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 4/4] Add git-rewrite-commits
Date: Sun, 8 Jul 2007 19:17:16 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707081911160.4248@racer.site> (raw)
In-Reply-To: <20070708173027.GK1528MdfPADPa@greensroom.kotnet.org>
Hi,
On Sun, 8 Jul 2007, Sven Verdoolaege wrote:
> On Sun, Jul 08, 2007 at 05:37:22PM +0100, Johannes Schindelin wrote:
> > That is to be expected. After all, the first is a script. However, I
> > really have ask: how often per hour do you want to run that program?
>
> I have a project that needs some cleaning-up and I'd like to do it
> incrementally. I think I'll have to run it about a dozen times.
A dozen times seems not that bad, especially since you can run both
programs on a limited set of commits. So the cost is not that big.
> > I am really unhappy that so much is talked about filtering out
> > commits. That is amost certainly not what you want in most cases.
> > In particular, I suspect that most users would expect the _changes_
> > filtered out by such a command, which is just not true.
>
> I don't care about that either. I'm just mentioning it because it's
> mentioned in the git-filter-branch documentation (which you added).
Which I copied. And this is not the first, let alone the only example in
filter-branch's documentation.
> > The second is to rewrite the commit messages so that the hashes are
> > mapped, too. But that should be relatively easy, too: you can provide
> > a message filter, and you can use the provided "map" function. If
> > this seems to be what many people need, you can write a simple
> > function and put it into filter-branch for common use.
>
> It's not going to be me (as I sais, I don't like shell programming).
Yes, you made that clear.
However, this leaves things only in half-finished states.
- "git filter-branch" did not learn the useful features that you seem to
need, and
- your builtin is at most a start of a builtin replacement for
filter-branch, which changes the semantics, to be sure.
I have no doubts that it will stay that way for a while, since this
builtin seems to be good enough for what you want it to do.
Ciao,
Dscho
next prev parent reply other threads:[~2007-07-08 18:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 16:23 [PATCH 0/4] Add git-rewrite-commits skimo
2007-07-08 16:23 ` [PATCH 1/4] export get_short_sha1 skimo
2007-07-08 16:23 ` [PATCH 2/4] export add_ref_decoration skimo
2007-07-08 16:23 ` [PATCH 3/4] revision: mark commits that didn't match a pattern for later use skimo
2007-07-08 16:23 ` [PATCH 4/4] Add git-rewrite-commits skimo
2007-07-08 16:37 ` Johannes Schindelin
2007-07-08 17:30 ` Sven Verdoolaege
2007-07-08 18:17 ` Johannes Schindelin [this message]
2007-07-08 19:11 ` Sven Verdoolaege
2007-07-08 18:04 ` Steven Grimm
2007-07-08 18:15 ` Sven Verdoolaege
2007-07-08 18:41 ` Johannes Schindelin
2007-07-08 21:10 ` Sven Verdoolaege
2007-07-09 9:01 ` Johannes Sixt
2007-07-09 9:48 ` Sven Verdoolaege
2007-07-09 11:57 ` Johannes Schindelin
2007-07-08 23:56 ` Johannes Schindelin
2007-07-09 9:47 ` Sven Verdoolaege
2007-07-09 12:57 ` Johannes Schindelin
2007-07-09 13:49 ` Sven Verdoolaege
2007-07-09 14:11 ` Johannes Schindelin
2007-07-09 14:42 ` Sven Verdoolaege
2007-07-09 14:59 ` Johannes Schindelin
2007-07-09 12:36 ` Jeff King
2007-07-09 13:16 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707081911160.4248@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=skimo@liacs.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).