git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] sha1_name.c: no need to include diff.h; tree-walk.h will do.
@ 2006-04-19 20:01 Junio C Hamano
  2006-04-19 20:50 ` Linus Torvalds
  0 siblings, 1 reply; 2+ messages in thread
From: Junio C Hamano @ 2006-04-19 20:01 UTC (permalink / raw
  To: git


Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 * Just a clean-up, comes on top of the one that returns mode
   from get_tree_entry().

 sha1_name.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sha1_name.c b/sha1_name.c
index 35e8dfb..7ad20b5 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -3,7 +3,7 @@ #include "tag.h"
 #include "commit.h"
 #include "tree.h"
 #include "blob.h"
-#include "diff.h"
+#include "tree-walk.h"
 
 static int find_short_object_filename(int len, const char *name, unsigned char *sha1)
 {
-- 
1.3.0.g2c4a

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sha1_name.c: no need to include diff.h; tree-walk.h will do.
  2006-04-19 20:01 [PATCH] sha1_name.c: no need to include diff.h; tree-walk.h will do Junio C Hamano
@ 2006-04-19 20:50 ` Linus Torvalds
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2006-04-19 20:50 UTC (permalink / raw
  To: Junio C Hamano; +Cc: git



On Wed, 19 Apr 2006, Junio C Hamano wrote:
>
>  * Just a clean-up, comes on top of the one that returns mode
>    from get_tree_entry().

Ack (along with the mode addition).

However, since the function is now no longer private to the SHA1 name 
lookup, I wonder if it might not be more logically put into "tree-walk.c" 
instead of "sha1_name.c".

Just a thought.

		Linus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-04-19 20:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-19 20:01 [PATCH] sha1_name.c: no need to include diff.h; tree-walk.h will do Junio C Hamano
2006-04-19 20:50 ` Linus Torvalds

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).