From: Linus Torvalds <torvalds@osdl.org>
To: "Randal L. Schwartz" <merlyn@stonehenge.com>
Cc: git@vger.kernel.org
Subject: Re: daemon.c broken on OpenBSD
Date: Mon, 24 Oct 2005 09:02:04 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0510240901020.10477@g5.osdl.org> (raw)
In-Reply-To: <867jc336f4.fsf@blue.stonehenge.com>
On Sun, 23 Oct 2005, Randal L. Schwartz wrote:
>
> If that rings a bell, help me out here. I'm guessing "isalnum" is getting
> defined (wrongly). Yeah, looks like in cache.h. Why is this getting
> defined?
We're doing our own ctype.h.
The fix is to make sure that "cache.h" is included _after_ system
includes.
iow, this should fix it, methinks.
Linus
---
diff --git a/daemon.c b/daemon.c
index 0c6182f..6e5de11 100644
--- a/daemon.c
+++ b/daemon.c
@@ -1,5 +1,3 @@
-#include "cache.h"
-#include "pkt-line.h"
#include <signal.h>
#include <sys/wait.h>
#include <sys/socket.h>
@@ -10,6 +8,9 @@
#include <arpa/inet.h>
#include <syslog.h>
+#include "cache.h"
+#include "pkt-line.h"
+
static int log_syslog;
static int verbose;
next prev parent reply other threads:[~2005-10-24 16:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 4:06 daemon.c broken on OpenBSD Randal L. Schwartz
2005-10-24 5:20 ` Junio C Hamano
2005-10-24 14:03 ` Matthias Urlichs
2005-10-25 23:29 ` Randal L. Schwartz
2005-10-25 23:32 ` Randal L. Schwartz
2005-10-25 23:40 ` Randal L. Schwartz
2005-10-24 16:02 ` Linus Torvalds [this message]
2005-10-24 16:06 ` Randal L. Schwartz
2005-10-24 16:43 ` Linus Torvalds
2005-10-24 17:04 ` H. Peter Anvin
2005-10-24 17:14 ` Linus Torvalds
2005-10-24 17:26 ` H. Peter Anvin
2005-10-24 17:58 ` Linus Torvalds
2005-10-24 18:03 ` H. Peter Anvin
2005-10-24 18:25 ` Morten Welinder
2005-10-24 20:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0510240901020.10477@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=merlyn@stonehenge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).