From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Uwe Kleine-König" <zeisberg@informatik.uni-freiburg.de>
Cc: git@vger.kernel.org, junkio@cox.net
Subject: Re: [PATCH 1/2] libgit.a: add some UTF-8 handling functions
Date: Sat, 23 Dec 2006 15:12:13 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.63.0612231510130.19693@wbgn013.biozentrum.uni-wuerzburg.de> (raw)
In-Reply-To: <20061223085206.GA2189@cepheus>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1045 bytes --]
Hi,
On Sat, 23 Dec 2006, Uwe Kleine-König wrote:
> Johannes Schindelin wrote:
> > @@ -127,6 +128,15 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)
> > while (fgets(comment, sizeof(comment), stdin) != NULL)
> > add_buffer(&buffer, &size, "%s", comment);
> >
> > + /* And check the encoding */
> > + buffer[size] = '\0';
> > + if (!strcmp(git_commit_encoding, "utf-8") && !is_utf8(buffer)) {
> Maybe you could be more generous here. E.g.
>
> if ((!strcasecmp(git_commit_encoding, "utf-8") ||
> !strcasecmp(git_commit_encoding, "utf8")) && !is_utf8(buffer))
>
> Junio suggested to make this check if i18n.commitEncoding is empty. I
> didn't check the code to see if this case is included.
The problem is, as I pointed out in another mail, that environment.c sets
the default git_commit_encoding to "utf-8". This is hardwired, and I have
no way to check if that was set by the config or not, other than reparsing
the config myself.
> Gruessle
Hah! You don't use umlauts and ssharp yourself!
Ciao,
Dscho
next prev parent reply other threads:[~2006-12-23 14:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 11:44 [PATCH] Fix documentation copy&paste typo Uwe Kleine-Koenig
2006-12-19 14:16 ` Uwe Kleine-König
2006-12-19 17:27 ` Junio C Hamano
2006-12-21 8:59 ` specify charset for commits (Was: [PATCH] Fix documentation copy&paste typo) Uwe Kleine-König
2006-12-21 9:51 ` Johannes Schindelin
2006-12-21 10:11 ` Santi Béjar
2006-12-21 10:23 ` Alexander Litvinov
2006-12-21 10:52 ` Jakub Narebski
2006-12-21 13:05 ` Alexander Litvinov
2006-12-21 13:14 ` Jakub Narebski
2006-12-21 13:43 ` Uwe Kleine-König
2006-12-21 18:19 ` specify charset for commits Junio C Hamano
2006-12-21 18:48 ` Nicolas Pitre
2006-12-21 19:11 ` Uwe Kleine-König
2006-12-21 19:36 ` Alexander Litvinov
2006-12-22 12:07 ` Johannes Schindelin
2006-12-22 15:09 ` Uwe Kleine-König
2006-12-22 22:02 ` Uwe Kleine-König
2006-12-22 15:31 ` Nicolas Pitre
2006-12-22 19:01 ` Junio C Hamano
2006-12-22 21:03 ` [PATCH 1/2] libgit.a: add some UTF-8 handling functions Johannes Schindelin
2006-12-22 21:27 ` Junio C Hamano
2006-12-22 21:36 ` Johannes Schindelin
2006-12-22 21:58 ` Junio C Hamano
2006-12-22 22:20 ` Johannes Schindelin
2006-12-22 22:33 ` Junio C Hamano
2006-12-25 4:03 ` Alexander Litvinov
2006-12-22 22:14 ` Uwe Kleine-König
2006-12-22 22:19 ` Uwe Kleine-König
2006-12-22 22:34 ` Johannes Schindelin
2006-12-22 23:50 ` Johannes Schindelin
2006-12-23 8:52 ` Uwe Kleine-König
2006-12-23 14:12 ` Johannes Schindelin [this message]
2006-12-23 19:53 ` warn non utf-8 commit log messages Junio C Hamano
2006-12-23 23:46 ` Johannes Schindelin
2006-12-22 21:06 ` [PATCH 2/2] git-commit-tree: if i18n.commitencoding is utf-8 (default), check it Johannes Schindelin
2006-12-22 21:50 ` Junio C Hamano
2006-12-22 22:21 ` Johannes Schindelin
2006-12-22 21:15 ` [RFC/PATCH 3/2] Wrap lines in shortlog Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.63.0612231510130.19693@wbgn013.biozentrum.uni-wuerzburg.de \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=zeisberg@informatik.uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).