From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <junkio@cox.net>
Cc: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] git-add --interactive (wip)
Date: Tue, 12 Dec 2006 23:15:56 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.63.0612122311400.2807@wbgn013.biozentrum.uni-wuerzburg.de> (raw)
In-Reply-To: <7vwt4wpytm.fsf@assigned-by-dhcp.cox.net>
Hi,
On Tue, 12 Dec 2006, Junio C Hamano wrote:
> I've updated my "git add --interactive" in 'pu' and it now knows how to
> split a hunk into smaller pieces and recounting the diff offsets before
> applying (Johannes pointed out that his partial commit script, entirely
> written in bash using shell arrays, has a similar feature. I guess I
> should have stolen his code instead of lifting the logic from my own
> abandoned porcelain).
Well, not completely true. I do not split hunks into subhunks.
Note that you _could_ split hunks at arbitrary lines; if it is a line
common between the two files, it is easier though.
And you could not have ripped from my script: I make heavy use of bash
arrays (in fact, I wrote this script partly to learn how to work with bash
arrays). If I could think of a clean way to spawn processes piped into
"less -FS" several times from a C program, I would already have rewritten
it in C.
> So in short, I think per-hunk update-index is a cute hack and may be
> useful in a narrow simple cases, but it would not be so useful in the
> real life.
To the contrary! In spite of having written git-hunk-commit to please
those poor souls coming from the darcs side, I already used it myself
quite often! I think it is a killer feature.
Ciao,
Dscho
next prev parent reply other threads:[~2006-12-12 22:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 12:36 git-commit: select which files to commit while editing the commit message Pazu
2006-12-08 19:18 ` Junio C Hamano
2006-12-08 19:32 ` Jakub Narebski
2006-12-08 20:45 ` Luben Tuikov
2006-12-08 22:10 ` Josef Weidendorfer
2006-12-08 23:59 ` Seth Falcon
2006-12-09 0:07 ` Jakub Narebski
2006-12-09 0:37 ` Seth Falcon
2006-12-09 0:59 ` Junio C Hamano
2006-12-10 0:46 ` Josef Weidendorfer
2006-12-10 0:54 ` Junio C Hamano
2006-12-11 9:23 ` [PATCH] git-add --interactive (wip) Junio C Hamano
2006-12-11 10:47 ` Josef Weidendorfer
2006-12-12 21:51 ` Junio C Hamano
2006-12-12 22:15 ` Johannes Schindelin [this message]
2006-12-13 9:20 ` Andreas Ericsson
2006-12-13 3:15 ` Josef Weidendorfer
2006-12-13 5:34 ` Junio C Hamano
2006-12-13 10:42 ` Johannes Schindelin
2006-12-13 10:57 ` Shawn Pearce
2006-12-13 11:20 ` Johannes Schindelin
2006-12-13 20:31 ` Josef Weidendorfer
2006-12-09 7:02 ` git-commit: select which files to commit while editing the commit message Sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.63.0612122311400.2807@wbgn013.biozentrum.uni-wuerzburg.de \
--to=johannes.schindelin@gmx.de \
--cc=Josef.Weidendorfer@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).