From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Junio C Hamano <junkio@cox.net>, sf <sf-gmane@stephan-feder.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/3] sha1_file: add the ability to parse objects in "pack file format"
Date: Wed, 12 Jul 2006 02:39:26 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.63.0607120226210.29667@wbgn013.biozentrum.uni-wuerzburg.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0607111656250.5623@g5.osdl.org>
Hi,
On Tue, 11 Jul 2006, Linus Torvalds wrote:
> On Tue, 11 Jul 2006, Junio C Hamano wrote:
> >
> > I do not like to rely too heavily on what zlib compression's
> > beginning of stream looks like.
>
> Well, I normally would agree with you if it was a "oh, all our zlib
> objects seem to start with 0x78" thing, but after having dug into both the
> zlib standard (which is actually an RFC, not just some random thing), and
> looked at the sources, it's definitely the case that the "0x78" byte isn't
> just an implementation detail.
>
> It's actually really part of the specs, and not just happenstance.
Good.
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -684,26 +684,74 @@ static void *map_sha1_file_internal(cons
> return map;
> }
>
> -static int unpack_sha1_header(z_stream *stream, void *map, unsigned long mapsize, void *buffer, unsigned long size)
> +static int unpack_sha1_header(z_stream *stream, unsigned char *map, unsigned long mapsize, void *buffer, unsigned long bufsiz)
> {
> + unsigned char c;
> + unsigned int word, bits;
> + unsigned long size;
> + static const char *typename[8] = {
> + NULL, /* OBJ_EXT */
> + "commit", "tree", "blob", "tag",
> + NULL, NULL, NULL
> + };
I completely forgot to mention that type_names[] is already declared in
object.h. Obviously, it is not really important, but maybe it would be
better to obey the DRY principle (think addition of "bind" object type).
> + while (!(c & 0x80)) {
> + if (bits >= 8*sizeof(long))
Another nit: while it is safe to assume that sizeof(long) ==
sizeof(unsigned long), it was nevertheless a little confusing to yours
truly (especially since you changed it since your last patch).
> static void *unpack_sha1_rest(z_stream *stream, void *buffer, unsigned long size)
> {
> int bytes = strlen(buffer) + 1;
> unsigned char *buf = xmalloc(1+size);
> + unsigned long n;
>
> - memcpy(buf, (char *) buffer + bytes, stream->total_out - bytes);
> - bytes = stream->total_out - bytes;
> + n = stream->total_out - bytes;
> + if (n > size)
> + n = size;
Just out of curiosity: when can this happen? I mean, there is no error or
something which could tell the caller that not the whole object was
copied.
> memset(&stream, 0, sizeof(stream));
> deflateInit(&stream, zlib_compression_level);
> - size = deflateBound(&stream, len+hdrlen);
> + size = 8 + deflateBound(&stream, len+hdrlen);
Again, I had to think why this is correct. I think it should be something
like 2 + sizeof(unsigned long) * 8 / 7, but I did not think all that hard.
It looks good to me, but I did not really test...
Ciao,
Dscho
next prev parent reply other threads:[~2006-07-12 0:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 23:01 Revisiting large binary files issue Carl Baldwin
2006-07-10 23:14 ` Junio C Hamano
2006-07-11 6:20 ` Peter Baumann
2006-07-10 23:28 ` Linus Torvalds
2006-07-11 9:40 ` [RFC]: Pack-file object format for individual objects (Was: Revisiting large binary files issue.) sf
2006-07-11 18:00 ` Linus Torvalds
2006-07-11 21:45 ` sf
2006-07-11 22:17 ` Linus Torvalds
2006-07-11 22:26 ` Linus Torvalds
2006-07-11 14:55 ` Revisiting large binary files issue Carl Baldwin
2006-07-11 17:09 ` Linus Torvalds
2006-07-11 17:10 ` [PATCH 1/3] Make the unpacked object header functions static to sha1_file.c Linus Torvalds
2006-07-11 17:12 ` [PATCH 2/3] sha1_file: add the ability to parse objects in "pack file format" Linus Torvalds
2006-07-11 18:40 ` Johannes Schindelin
2006-07-11 18:58 ` Linus Torvalds
2006-07-11 19:20 ` Johannes Schindelin
2006-07-11 19:48 ` Linus Torvalds
2006-07-11 21:25 ` Johannes Schindelin
2006-07-11 21:47 ` Junio C Hamano
2006-07-11 21:24 ` sf
2006-07-11 22:09 ` Linus Torvalds
2006-07-11 22:25 ` sf
2006-07-11 23:03 ` Junio C Hamano
2006-07-12 0:03 ` Linus Torvalds
2006-07-12 0:39 ` Johannes Schindelin [this message]
2006-07-12 3:45 ` Linus Torvalds
2006-07-12 4:31 ` Linus Torvalds
2006-07-12 6:35 ` Junio C Hamano
2006-07-12 16:29 ` Linus Torvalds
2006-07-12 0:46 ` Junio C Hamano
2006-07-12 3:42 ` Linus Torvalds
2006-07-12 6:49 ` Peter Baumann
2006-07-12 7:16 ` Junio C Hamano
2006-07-12 8:28 ` Peter Baumann
2006-07-12 15:13 ` Linus Torvalds
2006-07-12 15:27 ` Junio C Hamano
2006-07-11 17:16 ` [PATCH 3/3] Enable the new binary header format for unpacked objects Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.63.0607120226210.29667@wbgn013.biozentrum.uni-wuerzburg.de \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=sf-gmane@stephan-feder.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).