* t9001 fails because Net::SMTP is missing
@ 2006-05-30 19:26 Johannes Schindelin
2006-05-31 0:34 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Schindelin @ 2006-05-30 19:26 UTC (permalink / raw
To: git
Hi,
is it unexpected that there are setups which come without Net::SMTP?
-- snip --
* expecting success: git format-patch -n HEAD^1
git send-email -from="Example <nobody@example.com>"
--to=nobody@example.com --smtp-server="$(pwd)/fake.sendmail" ./0001*txt
0001-Second.txt
Can't locate Net/SMTP.pm in @INC (@INC contains:
/System/Library/Perl/darwin /System/Library/Perl /Library/Perl/darwin
/Library/Perl /Library/Perl /Network/Library/Perl/darwin
/Network/Library/Perl /Network/Library/Perl .) at
/Users/gene099/my/git-current/t/../git-send-email line 24.
BEGIN failed--compilation aborted at
/Users/gene099/my/git-current/t/../git-send-email line 24.
* FAIL 3: Extract patches and send
-- snap --
Ciao,
Dscho
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: t9001 fails because Net::SMTP is missing
2006-05-30 19:26 t9001 fails because Net::SMTP is missing Johannes Schindelin
@ 2006-05-31 0:34 ` Junio C Hamano
2006-05-31 0:37 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2006-05-31 0:34 UTC (permalink / raw
To: Johannes Schindelin; +Cc: git
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> is it unexpected that there are setups which come without Net::SMTP?
>
> -- snip --
> * expecting success: git format-patch -n HEAD^1
> git send-email -from="Example <nobody@example.com>"
> --to=nobody@example.com --smtp-server="$(pwd)/fake.sendmail" ./0001*txt
> 0001-Second.txt
> Can't locate Net/SMTP.pm in @INC (@INC contains:
Hmm. Something like this?
-- >8 --
diff --git a/git-send-email.perl b/git-send-email.perl
index 0e368ff..f7af8eb 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -21,7 +21,6 @@ use warnings;
use Term::ReadLine;
use Getopt::Long;
use Data::Dumper;
-use Net::SMTP;
# most mail servers generate the Date: header, but not all...
$ENV{LC_ALL} = 'C';
@@ -394,6 +393,7 @@ X-Mailer: git-send-email $gitversion
print $sm "$header\n$message";
close $sm or die $?;
} else {
+ use Net::SMTP;
$smtp ||= Net::SMTP->new( $smtp_server );
$smtp->mail( $from ) or die $smtp->message;
$smtp->to( @recipients ) or die $smtp->message;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: t9001 fails because Net::SMTP is missing
2006-05-31 0:34 ` Junio C Hamano
@ 2006-05-31 0:37 ` Junio C Hamano
2006-05-31 2:07 ` Morten Welinder
2006-05-31 6:05 ` Eric Wong
0 siblings, 2 replies; 6+ messages in thread
From: Junio C Hamano @ 2006-05-31 0:37 UTC (permalink / raw
To: git; +Cc: Johannes Schindelin
Junio C Hamano <junkio@cox.net> writes:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>> is it unexpected that there are setups which come without Net::SMTP?
>>
>> -- snip --
>> * expecting success: git format-patch -n HEAD^1
>> git send-email -from="Example <nobody@example.com>"
>> --to=nobody@example.com --smtp-server="$(pwd)/fake.sendmail" ./0001*txt
>> 0001-Second.txt
>> Can't locate Net/SMTP.pm in @INC (@INC contains:
>
> Hmm. Something like this?
Nah, nevermind. I forgot my Perl that use has the magic BEGIN{}
block around it X-<.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: t9001 fails because Net::SMTP is missing
2006-05-31 0:37 ` Junio C Hamano
@ 2006-05-31 2:07 ` Morten Welinder
2006-05-31 6:05 ` Eric Wong
1 sibling, 0 replies; 6+ messages in thread
From: Morten Welinder @ 2006-05-31 2:07 UTC (permalink / raw
To: Junio C Hamano; +Cc: git, Johannes Schindelin
You just need more perl magic... Try this.
#!/usr/local/perl -w
eval 'use strict';
print "Hmm [$@]\n";
eval 'use Oink';
print "Hmm [$@]\n";
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: t9001 fails because Net::SMTP is missing
2006-05-31 0:37 ` Junio C Hamano
2006-05-31 2:07 ` Morten Welinder
@ 2006-05-31 6:05 ` Eric Wong
2006-05-31 8:32 ` Johannes Schindelin
1 sibling, 1 reply; 6+ messages in thread
From: Eric Wong @ 2006-05-31 6:05 UTC (permalink / raw
To: Junio C Hamano; +Cc: git, Johannes Schindelin
Junio C Hamano <junkio@cox.net> wrote:
> Junio C Hamano <junkio@cox.net> writes:
>
> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >
> >> is it unexpected that there are setups which come without Net::SMTP?
> >>
> >> -- snip --
> >> * expecting success: git format-patch -n HEAD^1
> >> git send-email -from="Example <nobody@example.com>"
> >> --to=nobody@example.com --smtp-server="$(pwd)/fake.sendmail" ./0001*txt
> >> 0001-Second.txt
> >> Can't locate Net/SMTP.pm in @INC (@INC contains:
> >
> > Hmm. Something like this?
>
> Nah, nevermind. I forgot my Perl that use has the magic BEGIN{}
> block around it X-<.
s/use/require/ and you should be fine. We don't need any thing imported
from Net::SMTP, either.
Odd that Net::SMTP isn't installed on Johannes' machine, though, as it's
part of the standard Perl 5.8 (maybe even before) installation.
--
Eric Wong
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: t9001 fails because Net::SMTP is missing
2006-05-31 6:05 ` Eric Wong
@ 2006-05-31 8:32 ` Johannes Schindelin
0 siblings, 0 replies; 6+ messages in thread
From: Johannes Schindelin @ 2006-05-31 8:32 UTC (permalink / raw
To: Eric Wong; +Cc: Junio C Hamano, git
Hi,
On Tue, 30 May 2006, Eric Wong wrote:
> Odd that Net::SMTP isn't installed on Johannes' machine, though, as it's
> part of the standard Perl 5.8 (maybe even before) installation.
In terms of corporate setups, 5.8 really is pretty new, you know?
As for "s/use/require/", I can not access on that machine today, but I
will test it.
Ciao,
Dscho
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-05-31 8:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-30 19:26 t9001 fails because Net::SMTP is missing Johannes Schindelin
2006-05-31 0:34 ` Junio C Hamano
2006-05-31 0:37 ` Junio C Hamano
2006-05-31 2:07 ` Morten Welinder
2006-05-31 6:05 ` Eric Wong
2006-05-31 8:32 ` Johannes Schindelin
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).