From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] rev-list: add "--objects=self-sufficient" flag.
Date: Thu, 7 Jul 2005 16:58:13 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0507071657140.25104@g5.osdl.org> (raw)
In-Reply-To: <7vfyuqfa6r.fsf_-_@assigned-by-dhcp.cox.net>
On Thu, 7 Jul 2005, Junio C Hamano wrote:
>
> - if (!strcmp(arg, "--objects")) {
> + if (!strncmp(arg, "--objects", 9)) {
> + if (!strcmp(arg+9, "=self-sufficient"))
> + objects_self_sufficient = 1;
This is nasty - if you mis-spell "self-sufficient" (easy enough to do)
you'll never know the end result isn't what you expected. It won't warn
you in any way, it will just make a non-self-sufficient pack..
Linus
next prev parent reply other threads:[~2005-07-07 23:58 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-03 23:46 [ANNOUNCE] Cogito-0.12 Petr Baudis
2005-07-06 12:01 ` Brian Gerst
2005-07-07 14:45 ` Petr Baudis
2005-07-07 17:21 ` Junio C Hamano
2005-07-07 19:04 ` Linus Torvalds
2005-07-07 19:57 ` Junio C Hamano
2005-07-07 21:58 ` Linus Torvalds
2005-07-07 22:10 ` Junio C Hamano
2005-07-07 20:00 ` Junio C Hamano
2005-07-07 21:29 ` Eric W. Biederman
2005-07-07 22:23 ` Linus Torvalds
2005-07-08 2:11 ` Eric W. Biederman
2005-07-08 1:54 ` Dumb servers (was: [ANNOUNCE] Cogito-0.12) Kevin Smith
2005-07-08 2:27 ` Linus Torvalds
2005-07-07 22:14 ` [ANNOUNCE] Cogito-0.12 Petr Baudis
2005-07-07 22:52 ` Linus Torvalds
2005-07-07 23:16 ` [PATCH] Pull efficiently from a dumb git store Junio C Hamano
2005-07-07 23:50 ` [PATCH] rev-list: add "--objects=self-sufficient" flag Junio C Hamano
2005-07-07 23:58 ` Linus Torvalds [this message]
2005-07-08 1:02 ` [PATCH] rev-list: add "--full-objects" flag Junio C Hamano
2005-07-08 1:33 ` Linus Torvalds
2005-07-08 1:46 ` Linus Torvalds
2005-07-08 2:17 ` Junio C Hamano
2005-07-08 2:39 ` Linus Torvalds
2005-07-09 21:09 ` Eric W. Biederman
2005-07-10 5:11 ` Linus Torvalds
2005-07-10 6:28 ` Junio C Hamano
2005-07-10 21:48 ` Sven Verdoolaege
2005-07-10 22:36 ` Linus Torvalds
2005-07-11 15:19 ` Eric W. Biederman
2005-07-11 16:38 ` Linus Torvalds
2005-07-12 0:44 ` Eric W. Biederman
2005-07-12 1:14 ` Linus Torvalds
2005-07-12 2:38 ` Eric W. Biederman
2005-07-12 3:21 ` Linus Torvalds
2005-07-12 3:39 ` Eric W. Biederman
2005-07-12 4:48 ` Linus Torvalds
2005-07-11 17:53 ` Linus Torvalds
[not found] ` <7vy88gzn6s.fsf@assigned-by-dhcp.cox.net>
[not found] ` <Pine.LNX.4.58.0507082109140.17536@g5.osdl.org>
[not found] ` <7vfyumj8hn.fsf_-_@assigned-by-dhcp.cox.net>
2005-07-11 7:00 ` [PATCH] Check packs and then files Junio C Hamano
2005-07-08 1:03 ` [PATCH] Give --full-objects flag to rev-list when preparing a dumb server Junio C Hamano
2005-07-07 23:50 ` [PATCH] Use --objects=self-sufficient flag to rev-list Junio C Hamano
2005-07-07 23:52 ` [ANNOUNCE] Cogito-0.12 Tony Luck
2005-07-07 23:54 ` Junio C Hamano
2005-07-07 23:59 ` Linus Torvalds
2005-07-08 0:09 ` Tony Luck
2005-07-08 0:23 ` Linus Torvalds
2005-07-09 21:58 ` Russell King
2005-07-09 22:29 ` Russell King
2005-07-09 23:46 ` Junio C Hamano
2005-07-10 5:02 ` Linus Torvalds
2005-07-10 5:15 ` Linus Torvalds
2005-07-10 6:55 ` Russell King
2005-07-10 7:15 ` Junio C Hamano
2005-07-10 12:46 ` Russell King
2005-07-10 16:51 ` Linus Torvalds
2005-07-10 19:15 ` Russell King
2005-07-10 20:03 ` Linus Torvalds
2005-07-10 20:32 ` Russell King
2005-07-10 21:40 ` Linus Torvalds
2005-07-10 8:09 ` Russell King
2005-07-10 14:59 ` Petr Baudis
2005-07-11 20:30 ` Chris Wright
2005-07-08 0:09 ` Linus Torvalds
2005-07-08 8:14 ` Petr Baudis
2005-07-08 15:56 ` Daniel Barkalow
2005-07-07 6:22 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0507071657140.25104@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).