From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Do not show empty diff in diff-cache uncached.
Date: Sun, 29 May 2005 11:53:56 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0505291151250.10545@ppc970.osdl.org> (raw)
In-Reply-To: <7vis13wth4.fsf_-_@assigned-by-dhcp.cox.net>
On Sat, 28 May 2005, Junio C Hamano wrote:
>
> Pre- "diff --git" built-in diff did not add any extended header
> on its own, so it did not show anything for unmodified but
> stat-dirty file from diff-cache command without --cached flag.
>
> Recent diff-cache produces "diff --git" header internally before
> calling the "diff" command, which results in an empty diff for
> such a file, cluttering the output. This patch fixes this.
I'm not sure I like this.
I actually _expect_ that "git-diff-files" will show files that don't match
the index, even if they happen to have the exact content that the index
points to. It's how I know whether the index is up-to-date or not.
The exact same thing is trye of git-diff-cache. If something isn't
up-to-date in the cache, you should show it, since certain operations
depend on the cache being updated.
Linus
next prev parent reply other threads:[~2005-05-29 18:49 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 0:41 Broken directory pathname pruning Linus Torvalds
2005-05-27 0:42 ` Junio C Hamano
2005-05-27 0:49 ` [PATCH] allow pathspec to end with a slash Junio C Hamano
2005-05-27 0:52 ` [PATCH] allow pathspec to end with a slash (take #2) Junio C Hamano
2005-05-27 6:41 ` [PATCH] Diff updates, fixing pathspec and rename/copy interaction Junio C Hamano
2005-05-27 15:56 ` Linus Torvalds
2005-05-27 18:22 ` Junio C Hamano
2005-05-27 22:43 ` [PATCH 00/12] Diff updates Junio C Hamano
2005-05-27 22:49 ` [PATCH 01/12] Fix math thinko in similarity estimator Junio C Hamano
2005-05-27 22:50 ` [PATCH 02/12] Introduce diff_free_filepair() funcion Junio C Hamano
2005-05-27 22:51 ` [PATCH 03/12] Make pathspec only care about the detination tree Junio C Hamano
2005-05-27 22:52 ` [PATCH 04/12] Remove unused rank field from diff_core structure Junio C Hamano
2005-05-27 22:53 ` [PATCH 05/12] Do not expose internal scaling to diff-helper Junio C Hamano
2005-05-27 22:54 ` [PATCH 06/12] Remove final newline from the value of xfrm_msg variable Junio C Hamano
2005-05-27 22:54 ` [PATCH 07/12] Clean up diff_setup() to make it more extensible Junio C Hamano
2005-05-27 22:55 ` [PATCH 08/12] Remove a function not used anymore Junio C Hamano
2005-05-27 22:55 ` [PATCH 09/12] Add --pickaxe-all to diff-* brothers Junio C Hamano
2005-05-27 22:55 ` [PATCH 10/12] Fix the way diffcore-rename records unremoved source Junio C Hamano
2005-05-27 22:56 ` [PATCH 11/12] Move pathspec to the beginning of the diffcore chain Junio C Hamano
2005-05-27 22:56 ` [PATCH 12/12] Optimize diff-tree -[CM] --stdin Junio C Hamano
2005-06-04 2:17 ` Yoichi Yuasa
2005-05-27 23:03 ` [PATCH 00/12] Diff updates Junio C Hamano
2005-05-28 10:11 ` [PATCH] Do not show empty diff in diff-cache uncached Junio C Hamano
2005-05-28 19:22 ` [PATCH] Diff: two fixes Junio C Hamano
2005-05-29 4:20 ` [PATCH] diff-helper: fix R/C score parsing under -z flag Junio C Hamano
2005-05-29 5:23 ` [PATCH] diff-cache: diff-patch (-p) format fixes Junio C Hamano
2005-05-29 9:10 ` [PATCH] diff: code clean-up Junio C Hamano
2005-05-29 18:53 ` Linus Torvalds [this message]
2005-05-29 20:09 ` [PATCH] Do not show empty diff in diff-cache uncached Junio C Hamano
2005-05-29 21:52 ` Junio C Hamano
2005-05-29 23:41 ` [PATCH 0/3] Leftover bits after 12-series Junio C Hamano
2005-05-29 23:54 ` [PATCH 1/3] diff-helper: Fix R/C score parsing under -z flag Junio C Hamano
2005-05-29 23:56 ` [PATCH 2/3] diff: consolidate various calls into diffcore Junio C Hamano
2005-05-29 23:56 ` [PATCH 3/3] diff: code clean-up and removal of rename hack Junio C Hamano
2005-05-30 6:58 ` [PATCH 0/4] Junio C Hamano
2005-05-30 7:07 ` [PATCH 1/4] diff: further cleanup Junio C Hamano
2005-05-30 7:08 ` [PATCH 2/4] diff: fix the culling of unneeded delete record Junio C Hamano
2005-05-30 7:08 ` [PATCH 3/4] Add -B flag to diff-* brothers Junio C Hamano
2005-05-30 7:09 ` [PATCH 4/4] Add -O<orderfile> option " Junio C Hamano
2005-05-30 5:34 ` [PATCH] Do not show empty diff in diff-cache uncached Linus Torvalds
2005-05-30 5:53 ` Junio C Hamano
2005-06-11 23:27 ` [PATCH] apply.c: tolerate diff from a dirty but unchanged path Junio C Hamano
2005-06-12 16:14 ` Linus Torvalds
2005-06-12 17:05 ` Linus Torvalds
2005-06-12 18:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0505291151250.10545@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).