git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] diff-cache/tree compatible output for show-diff (take 2).
Date: Tue, 26 Apr 2005 18:09:57 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0504261805070.18901@ppc970.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0504261750030.18901@ppc970.osdl.org>



On Tue, 26 Apr 2005, Linus Torvalds wrote:
> 
> I'll need to fix that up, because right now it does the wrong thing (which
> it has always done): since we _remove_ all the merge entries, we'll first
> warn about them, but then we'll show the original file going away if there
> was one. Which is bogus.

Fixed. I think. My solution is clever, but untested.

What I do is that instead of _removing_ the unmerged entries (which we 
can't do, or we'd later think that the file has gone away if we see that 
same name in the tree we're comparing against), I make all unmerged 
entries be in "stage 3".

Then, when we read in the tree to compare against into stage 1, we have a 
few cases:

 - stage 0 only: new file
 - stage 0 and 1: modified file
 - stage 1 only: deleted file
 - stage 1 and 3: unmerged
 - stage 3 only: unmerged

See any problems with this? (a mix of 0 and 3 cannot happen - a file is
either unmerged or it is ok, since inserting a stage 0 entry always
removes all unmerged entires).

		Linus

      parent reply	other threads:[~2005-04-27  1:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1113400651.20848.135.camel@hades.cambridge.redhat.com>
2005-04-24  5:09 ` [GIT PATCH] Selective diff-tree Linus Torvalds
2005-04-24  6:25   ` David Woodhouse
2005-04-24 17:15     ` Linus Torvalds
2005-04-24  7:40   ` Junio C Hamano
2005-04-24 17:20     ` Linus Torvalds
2005-04-25  5:12   ` [PATCH 0/2] diff-tree/diff-cache helper Junio C Hamano
2005-04-25  5:15     ` [PATCH 1/2] Split external diff command interface to a separate file Junio C Hamano
2005-04-25  5:17     ` [PATCH 2/2] Introduce diff-tree-helper Junio C Hamano
2005-04-26  1:38     ` [PATCH 0/2] diff-tree/diff-cache helper Linus Torvalds
2005-04-26  2:08       ` Nicolas Pitre
2005-04-26  7:39       ` Junio C Hamano
2005-04-26  7:57         ` [PATCH] Diff-tree-helper take two Junio C Hamano
2005-04-26 22:27       ` [PATCH] Add -r flag to show-diff for diff-cache/diff-tree like output Junio C Hamano
2005-04-26 22:40         ` Linus Torvalds
2005-04-26 23:05           ` Junio C Hamano
2005-04-26 23:44             ` Linus Torvalds
2005-04-27  0:05               ` Junio C Hamano
2005-04-27  0:22                 ` Linus Torvalds
2005-04-26 23:45             ` [PATCH] diff-cache/tree compatible output for show-diff (take 2) Junio C Hamano
2005-04-27  0:20               ` Linus Torvalds
2005-04-27  0:29                 ` Linus Torvalds
     [not found]                   ` <Pine.LNX.4.58.0504261750030.18901@ppc970.osdl.org>
2005-04-27  1:09                     ` Linus Torvalds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0504261805070.18901@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).