From: Daniel Barkalow <barkalow@iabervon.org>
To: Tony Luck <tony.luck@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Get commits from remote repositories by HTTP
Date: Sat, 16 Apr 2005 18:33:18 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.21.0504161827480.30848-100000@iabervon.org> (raw)
In-Reply-To: <12c511ca050416152452a4c620@mail.gmail.com>
On Sat, 16 Apr 2005, Tony Luck wrote:
> On 4/16/05, Daniel Barkalow <barkalow@iabervon.org> wrote:
> > + buffer = read_sha1_file(sha1, type, &size);
>
> You never free this buffer.
Ideally, this should all be rearranged to share the code with
read-tree, and it should be fixed in common.
> It would also be nice if you saved "tree" objects in some temporary file
> and did not install them until after you had fetched all the blobs and
> trees that this tree references. Then if your connection is interrupted
> you can just restart it.
It looks over everything relevant, even if it doesn't need to download
anything, so it should work to continue if it stops in between.
-Daniel
*This .sig left intentionally blank*
next prev parent reply other threads:[~2005-04-16 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-16 22:03 [PATCH] Get commits from remote repositories by HTTP Daniel Barkalow
2005-04-16 22:17 ` Martin Mares
2005-04-16 22:43 ` Daniel Barkalow
2005-04-16 22:24 ` Tony Luck
2005-04-16 22:33 ` Daniel Barkalow [this message]
2005-04-16 22:42 ` Adam Kropelin
2005-04-16 22:45 ` Daniel Barkalow
2005-04-16 22:52 ` Adam Kropelin
2005-04-17 3:16 ` tony.luck
2005-04-18 18:41 ` tony.luck
2005-04-18 18:47 ` Petr Baudis
2005-04-18 20:48 ` tony.luck
2005-04-16 22:32 ` Jan-Benedict Glaw
2005-04-16 22:37 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0504161827480.30848-100000@iabervon.org \
--to=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=tony.luck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).