From: "Henrik Grubbström" <grubba@roxen.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Git Mailing list" <git@vger.kernel.org>,
"Carlos Martín Nieto" <cmn@elego.de>
Subject: Re: [PATCH] lf_to_crlf_filter(): tell the caller we added "\n" when draining
Date: Mon, 19 Dec 2011 11:19:19 +0100 (CET) [thread overview]
Message-ID: <Pine.GSO.4.63.1112191114010.4136@shipon.roxen.com> (raw)
In-Reply-To: <7vaa6sgmt3.fsf_-_@alter.siamese.dyndns.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 532 bytes --]
On Fri, 16 Dec 2011, Junio C Hamano wrote:
> This can only happen when the input size is multiple of the
> buffer size of the cascade filter (16k) and ends with an LF,
> but in such a case, the code forgot to tell the caller that
> it added the "\n" it could not add during the last round.
We probably ought to have a corresponding test in the testsuite.
A blob consisting of a singe 'A' followed by 8192 linefeeds should
be sufficient to trigger the problems.
--
Henrik Grubbström grubba@roxen.com
Roxen Internet Software AB
next prev parent reply other threads:[~2011-12-19 10:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 17:40 Infinite loop in cascade_filter_fn() Henrik Grubbström
2011-11-25 14:31 ` Carlos Martín Nieto
2011-11-25 15:38 ` Carlos Martín Nieto
2011-11-25 16:14 ` Henrik Grubbström
2011-11-25 17:02 ` Carlos Martín Nieto
2011-11-26 22:48 ` Junio C Hamano
2011-11-28 10:48 ` Carlos Martín Nieto
2011-11-28 19:18 ` Junio C Hamano
2011-12-16 22:01 ` Junio C Hamano
2011-12-16 22:43 ` [PATCH] lf_to_crlf_filter(): tell the caller we added "\n" when draining Junio C Hamano
2011-12-19 10:19 ` Henrik Grubbström [this message]
2011-12-19 20:23 ` Junio C Hamano
2011-12-19 16:42 ` Infinite loop in cascade_filter_fn() Carlos Martín Nieto
2011-11-25 15:43 ` Henrik Grubbström
2011-11-25 15:53 ` Carlos Martín Nieto
2011-11-25 15:59 ` Henrik Grubbström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.63.1112191114010.4136@shipon.roxen.com \
--to=grubba@roxen.com \
--cc=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).