From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Nieder Subject: Re: [PATCH 3/7] builtin-help: make list_commands() a bit more generic Date: Sat, 26 Jul 2008 13:28:39 -0500 (CDT) Message-ID: References: <1217073292-27945-1-git-send-email-vmiklos@frugalware.org> <4f2b03391e3f85cf2224f97a2a7765d08707bd73.1217037178.git.vmiklos@frugalware.org> <68749731fe8de8b2a9ffc53963291aeab9256b82.1217037178.git.vmiklos@frugalware.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: git@vger.kernel.org To: Miklos Vajna X-From: git-owner@vger.kernel.org Sat Jul 26 20:29:55 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KMoWg-0000Ge-HA for gcvg-git-2@gmane.org; Sat, 26 Jul 2008 20:29:54 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbYGZS2w (ORCPT ); Sat, 26 Jul 2008 14:28:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753194AbYGZS2w (ORCPT ); Sat, 26 Jul 2008 14:28:52 -0400 Received: from smtp02.uchicago.edu ([128.135.12.75]:45813 "EHLO smtp02.uchicago.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753161AbYGZS2v (ORCPT ); Sat, 26 Jul 2008 14:28:51 -0400 Received: from harper.uchicago.edu (harper.uchicago.edu [128.135.12.7]) by smtp02.uchicago.edu (8.13.8/8.13.8) with ESMTP id m6QISdUc026637; Sat, 26 Jul 2008 13:28:40 -0500 Received: from localhost (jrnieder@localhost) by harper.uchicago.edu (8.12.10/8.12.10) with ESMTP id m6QISdTl016538; Sat, 26 Jul 2008 13:28:39 -0500 (CDT) X-Authentication-Warning: harper.uchicago.edu: jrnieder owned process doing -bs In-Reply-To: <68749731fe8de8b2a9ffc53963291aeab9256b82.1217037178.git.vmiklos@frugalware.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sat, 26 Jul 2008, Miklos Vajna wrote: > -static void list_commands(void) > +void list_commands(const char *prefix, const char *title) > { > - unsigned int longest = load_command_list(NULL); > + unsigned int longest = load_command_list(prefix); > const char *exec_path = git_exec_path(); > > if (main_cmds.cnt) { > - printf("available git commands in '%s'\n", exec_path); > + printf("available %s in '%s'\n", title, exec_path); > printf("----------------------------"); > mput_char('-', strlen(exec_path)); > putchar('\n'); Should this be printf("available %s in '%s'\n", title, exec_path); printf("----------------"); mput_char('-', strlen(exec_path) + strlen(title)); putchar('\n'); ? (same question goes for the if(other_cmds.cnt) block, too)