From: Mario Grgic <mario_grgic@hotmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: git bug: Perl compatible regular expressions do not work as expected
Date: Mon, 27 Mar 2023 13:22:29 -0400 [thread overview]
Message-ID: <MW4PR20MB5517E2591A77978709695AC3908B9@MW4PR20MB5517.namprd20.prod.outlook.com> (raw)
In-Reply-To: <xmqqcz4ucg1w.fsf@gitster.g>
In my case, I compiled git with pcre2 support, using third party PCRE2 library: https://github.com/PCRE2Project/pcre2
and PCRE and multibyte support in git works with it just fine.
E.g. adding and committing a file:
```
#!/usr/bin/env node
console.log('顔🏁');
```
and searching it with
git log --all -p -G '顔🏁’
works.
Again, perhaps the solution here is to distinguish two cases:
1. git is compiled with native regex library on macOS
2. git is compiled with third party regex library with PCRE and multibyte support on macOS
in case 2 everything works.
Case 1 is perhaps more work on macOS and a feature request.
> On Mar 27, 2023, at 12:30 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> Mario Grgic <mario_grgic@hotmail.com> writes:
>
>> Confirming that putting back NO_REGEX = YesPlease in the Makefile fixes the problem. I.e. the following patch fixes it for me:
>>
>> --- Makefile 2023-03-25 11:24:01.000000000 -0400
>> +++ Makefile.patched 2023-03-25 11:25:11.000000000 -0400
>> @@ -1554,6 +1554,7 @@
>> APPLE_COMMON_CRYPTO = YesPlease
>> COMPAT_CFLAGS += -DAPPLE_COMMON_CRYPTO
>> endif
>> + NO_REGEX = YesPlease
>> PTHREAD_LIBS =
>> endif
>
> It will unfortunately break multibyte support on macOS by reverting
> what 1819ad32 (grep: fix multibyte regex handling under macOS,
> 2022-08-26) did.
next prev parent reply other threads:[~2023-03-27 17:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 12:31 git bug: Perl compatible regular expressions do not work as expected Mario Grgic
2023-03-25 12:42 ` Kristoffer Haugsbakk
2023-03-25 12:59 ` Mario Grgic
2023-03-25 13:04 ` demerphq
2023-03-25 13:09 ` Mario Grgic
2023-03-25 13:24 ` demerphq
2023-03-25 18:09 ` René Scharfe
2023-03-27 16:29 ` Junio C Hamano
2023-03-27 17:23 ` René Scharfe
2023-03-27 21:33 ` Junio C Hamano
2023-03-28 13:47 ` Junio C Hamano
2023-03-28 17:56 ` René Scharfe
2023-03-25 14:16 ` Mario Grgic
2023-03-25 15:39 ` Mario Grgic
2023-03-27 16:30 ` Junio C Hamano
2023-03-27 17:22 ` Mario Grgic [this message]
2023-03-27 21:11 ` Junio C Hamano
2023-03-28 0:03 ` Mario Grgic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR20MB5517E2591A77978709695AC3908B9@MW4PR20MB5517.namprd20.prod.outlook.com \
--to=mario_grgic@hotmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).