From: Kirill Likhodedov <Kirill.Likhodedov@jetbrains.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: git log doesn't allow %x00 in custom format anymore?
Date: Thu, 7 Oct 2010 19:18:18 +0400 [thread overview]
Message-ID: <FF2FF369-0B1C-457E-A86E-8651BF0A82CB@jetbrains.com> (raw)
In-Reply-To: <4CADE232.8030801@viscovery.net>
> With git rev-list, it also happens on Linux:
>
> $ git log -1 --pretty=foo%x00bar HEAD | od -c
> 0000000 f o o \0 b a r \n
> 0000010
> $ git rev-list -1 --pretty=foo%x00bar HEAD | od -c
> 0000000 c o m m i t 8 7 f a f 1 0 9 0
> 0000020 5 d 1 f 8 a b 1 e 9 a c 2 4 c c
> 0000040 3 e f e d 8 1 f a 7 e 2 9 6 7 \n
> 0000060 f o o \n
> 0000064
> $ git version
> git version 1.7.3.67.gcc234
>
Hannes,
Thanks for pointing that out.
I confirm that on Mac OS X that happens for rev-list as well.
# git log --pretty=format:foo%x00bar HEAD -1 | od -c
0000000 f o o \0 b a r
0000007
# git rev-list --pretty=format:foo%x00bar HEAD -1 | od -c
0000000 c o m m i t 2 3 6 0 1 a 2 c 3
0000020 e 4 6 4 a 4 4 7 9 f 1 7 7 4 e 3
0000040 6 e a 5 b 9 5 8 b 4 6 0 5 2 1 \n
0000060 f o o \n
0000064
And it's not a new issue:
# git version
git version 1.7.1
So here's what we have now about this bug:
1. It happens since 1.7.1 for rev-list on all platforms (at least since 1.7.1 on Mac OS X and 1.7.3 on Linux).
2. It also happens at least since 1.7.2.3 for log on Windows.
Sorry for giving some confusion in my previous messages.
I probably tested 'rev-list' at the time when I've recovered the problem, but I reported it as a problem with 'log'.
----------------------------------
Kirill Likhodedov
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"
next prev parent reply other threads:[~2010-10-07 15:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 11:25 git log doesn't allow %x00 in custom format anymore? Kirill Likhodedov
2010-10-07 14:10 ` Jeff King
2010-10-07 14:35 ` Kirill Likhodedov
2010-10-07 14:46 ` Jeff King
2010-10-07 15:07 ` Johannes Sixt
2010-10-07 15:18 ` Kirill Likhodedov [this message]
2010-10-07 17:29 ` Jeff King
2010-10-07 17:40 ` Matthieu Moy
2010-10-07 18:02 ` Drew Northup
2010-10-07 17:41 ` Erik Faye-Lund
2010-10-07 17:43 ` Erik Faye-Lund
2010-10-07 17:50 ` Jeff King
2010-10-07 17:52 ` Matthieu Moy
2010-10-07 17:53 ` Jeff King
2010-10-07 18:05 ` Erik Faye-Lund
2010-10-07 18:13 ` Jeff King
2010-10-07 18:19 ` Erik Faye-Lund
2010-10-07 18:33 ` Jeff King
2010-10-07 18:37 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FF2FF369-0B1C-457E-A86E-8651BF0A82CB@jetbrains.com \
--to=kirill.likhodedov@jetbrains.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).