Re: [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

["Philip Oakley" <philipoakley@iee.org>]

From: "Eric Sunshine" <sunshine@sunshineco.com>
> On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley <philipoakley@iee.org> 
> wrote:
>> Keep the build clean of extraneous files if it is indeed clean.
>> Otherwise leave the msvc-build-makedryerrors.txt file both as
>> a flag for any CI system or for manual debugging.
>>
>> Note that the file will contain the new values of the GIT_VERSION
>> and GITGUI_VERSION if they were generated by the make file. They
>> are omitted if the release is tagged and indentically defined in
>> their respective GIT_VERSION_GEN file DEF_VER variables.
>>
>> Signed-off-by: Philip Oakley <philipoakley@iee.org>
>> ---
>> diff --git a/contrib/buildsystems/engine.pl 
>> b/contrib/buildsystems/engine.pl
>> index a6999b6..020776e 100755
>> --- a/contrib/buildsystems/engine.pl
>> +++ b/contrib/buildsystems/engine.pl
>> @@ -77,6 +77,8 @@ EOM
>>
>>  my $ErrsFile = "msvc-build-makedryerrors.txt";
>>  @makedry = `cd $git_dir && make -n MSVC=1 V=1 2>$ErrsFile` if 
>> !@makedry;
>> +# test for an empty Errors file and remove it
>> +for ($ErrsFile) {unlink $_ if (-f $_) && (!-s $_);}
>
> Why the 'for' loop?
>
> Also, if you're using the 'for' loop for the $_ side-effect, then why
> not the simpler:

It was cargo cult programming, with some Google searching to select 
between invocations. Most examples were looping through lists in 
scripts, hence the down select.

>
>    for ($ErrsFile) { unlink if -f && !-s; }

A lot better. Will fix.

>
> ?
>
>>
>>  # Parse the make output into usable info
>>  parseMakeOutput();
>> --
>> 2.4.2.windows.1.5.gd32afb6
>

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.