From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id B2AF81F487 for ; Thu, 26 Mar 2020 00:37:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727590AbgCZAhc (ORCPT ); Wed, 25 Mar 2020 20:37:32 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:45413 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727536AbgCZAhc (ORCPT ); Wed, 25 Mar 2020 20:37:32 -0400 Received: by mail-qt1-f194.google.com with SMTP id t17so3900539qtn.12 for ; Wed, 25 Mar 2020 17:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=S9IZclsWLZMnGEUrKs4qZMTW9nfvF7wjMauw+lOnH+s=; b=EC20bRY+9emYsFyXMvjqnBYrTR2RSdWrce1CA5FDUT5A/78FWwukVdzFnQsOEIjVdO cdvoosLyR+bWIa7BiX6avq4Cfv6biKh6u1TH0ARYr36gSNPZyPEXi9G5nSE2sY0msNVD cr/1WazstLX4W9bhJviDirfzG3WVHLs0zpSZHgvQ3vr00WNgRUo31WlE+Kfz964Bo6K3 B0z/6gtm6YAaeFHMYdhfyHpcOnwbl1dWQf/0yrriXwQuFGcARP94OP2PsFk7NhoNxgc2 QMIY7He2UxcZ92aLV1io1ieUF3Ej7YHdr2ptVZKuaZTPHuzh0o4yNyGP2oex+6M2PDmh MSNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=S9IZclsWLZMnGEUrKs4qZMTW9nfvF7wjMauw+lOnH+s=; b=Yv8FS57QOUvDB0481127Hf+pc7fSx+Acnv+ETXMoaIKsANTZC9i0VczpwzWlx1wNec 8OQFOivN8Ipi1jMdYQmZvz979g6V20Bk3p/qEu/XyfMH+2U8TYnIAeh/snHuj0VxiX+B QQnERI0CTyKVBj+zdTm16T8AZE4W3Wz/4ROuX6vmu6KvD0v6UnMeO3dcM2XpKNOOXFjW tBGXXVi8Ahgm9hice0E9l+3M31URsq0BZ8XO4IjCZv8Rk33JdgEpZVKxQIqZOusatkfZ nib1n5m5kltYqCx0keHOFLqCMkJbtadcdkP7Emf6vzv5x31z+UmDY9BKiM8XbqOWXEwf Ue5g== X-Gm-Message-State: ANhLgQ1upaPImCtXRJ2g04bRFTcJA2qfoHzBEHtfa4+IZ06/hfKVvvcx Lv8GmaOM2gedpQkhOeUnXN2xYN6nUm0= X-Google-Smtp-Source: ADFU+vs1VgKIanoeleFKEgs1GJv+NqzdPyfuxhqZBm1JyQ0rQBwbfy5jT/0yT2/QFd2aOmCJsNi6Hw== X-Received: by 2002:aed:25a7:: with SMTP id x36mr5606586qtc.203.1585183051464; Wed, 25 Mar 2020 17:37:31 -0700 (PDT) Received: from [192.168.2.21] ([142.118.142.146]) by smtp.googlemail.com with ESMTPSA id w132sm356308qkb.96.2020.03.25.17.37.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Mar 2020 17:37:30 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: Git doesn't support symlinks From: Daniel Malendez In-Reply-To: Date: Wed, 25 Mar 2020 20:37:30 -0400 Cc: Git Users Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Bryan Turner X-Mailer: Apple Mail (2.3608.60.0.2.5) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Thanks for your feedback! > On Mar 25, 2020, at 8:23 PM, Bryan Turner = wrote: >=20 > This didn't add the same thing. What does a "git status" show at this > point? I'd expect it would show "Versions/Current/Headers/interior.h" > as added to the index, not "Headers/interior.h". $ git add . $ git status Changes to be committed: (use "git rm --cached ..." to unstage) new file: Foo.framework/Headers new file: Foo.framework/Versions/A/Headers/Interior.h > It doesn't necessarily seem like a bug, to me; more like a case where > Git could potentially be "smarter" to try and determine that, while > "Headers/interior.h" is beyond a symlink, the target of that symlink > is still in the repository. (Versions/Current _is_ in the same > repository, right?) Agree, makes sense! I think what happens here is that `git add .` adds the = Foo.framework/Headers directory first, to circumvent this check failing = here? https://github.com/git/git/blob/master/pathspec.c#L596 Whereas a single =E2=80=9Cgit add path/to/file=E2=80=9D would fail here=