* 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column
@ 2018-05-26 20:45 Jeff Felchner
2018-05-26 21:07 ` Todd Zullinger
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Felchner @ 2018-05-26 20:45 UTC (permalink / raw)
To: git
Ever since 2.17.0, when saving a patch (using add --patch but probably other ways as well), if the whitespace is removed from the initial column, the patch doesn't apply.
Full walkthrough (including comparison with 2.16.3) in the video attached to this link:
https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column
2018-05-26 20:45 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column Jeff Felchner
@ 2018-05-26 21:07 ` Todd Zullinger
2018-05-27 4:16 ` Jeff Felchner
0 siblings, 1 reply; 3+ messages in thread
From: Todd Zullinger @ 2018-05-26 21:07 UTC (permalink / raw)
To: Jeff Felchner; +Cc: git, Phillip Wood
Hi Jeff,
Jeff Felchner wrote:
> Ever since 2.17.0, when saving a patch (using add --patch
> but probably other ways as well), if the whitespace is
> removed from the initial column, the patch doesn't apply.
This sounds a bit like the issue discussed in this thread a
few weeks ago:
https://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9adde8@talktalk.net/
But I didn't download or watch the video, so I'm not positive.
> Full walkthrough (including comparison with 2.16.3) in the
> video attached to this link:
>
> https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1
--
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Everybody knows how to raise children, except the people who have
them.
-- P.J. O'Rourke
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column
2018-05-26 21:07 ` Todd Zullinger
@ 2018-05-27 4:16 ` Jeff Felchner
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Felchner @ 2018-05-27 4:16 UTC (permalink / raw)
To: Todd Zullinger; +Cc: git, Phillip Wood
Todd, it looks like that may very well be the same issue. And it looks like it's planning on being fixed in the next release? Would that be 2.17.1 since it's a regression?
> On 2018 May 26, at 16:07, Todd Zullinger <tmz@pobox.com> wrote:
>
> Hi Jeff,
>
> Jeff Felchner wrote:
>> Ever since 2.17.0, when saving a patch (using add --patch
>> but probably other ways as well), if the whitespace is
>> removed from the initial column, the patch doesn't apply.
>
> This sounds a bit like the issue discussed in this thread a
> few weeks ago:
>
> https://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9adde8@talktalk.net/
>
> But I didn't download or watch the video, so I'm not positive.
>
>> Full walkthrough (including comparison with 2.16.3) in the
>> video attached to this link:
>>
>> https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1
>
> --
> Todd
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Everybody knows how to raise children, except the people who have
> them.
> -- P.J. O'Rourke
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-27 4:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-26 20:45 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column Jeff Felchner
2018-05-26 21:07 ` Todd Zullinger
2018-05-27 4:16 ` Jeff Felchner
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).