* [PATCH v1] git-p4: fix AsciiDoc formatting
@ 2016-03-01 11:05 larsxschneider
2016-03-13 17:46 ` Lars Schneider
0 siblings, 1 reply; 5+ messages in thread
From: larsxschneider @ 2016-03-01 11:05 UTC (permalink / raw
To: git; +Cc: sunshine, Lars Schneider
From: Lars Schneider <larsxschneider@gmail.com>
Noticed-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
Documentation/git-p4.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
index 738cfde..140fc12 100644
--- a/Documentation/git-p4.txt
+++ b/Documentation/git-p4.txt
@@ -528,7 +528,7 @@ git-p4.largeFileSystem::
git config git-p4.largeFileSystem GitLFS
-------------
+
- [1] https://git-lfs.github.com/
+[1] https://git-lfs.github.com/
git-p4.largeFileExtensions::
All files matching a file extension in the list will be processed
--
2.5.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] git-p4: fix AsciiDoc formatting
2016-03-01 11:05 [PATCH v1] git-p4: fix AsciiDoc formatting larsxschneider
@ 2016-03-13 17:46 ` Lars Schneider
2016-03-14 3:51 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Lars Schneider @ 2016-03-13 17:46 UTC (permalink / raw
To: git; +Cc: sunshine
On 01 Mar 2016, at 12:05, larsxschneider@gmail.com wrote:
> From: Lars Schneider <larsxschneider@gmail.com>
>
> Noticed-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
> Documentation/git-p4.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
> index 738cfde..140fc12 100644
> --- a/Documentation/git-p4.txt
> +++ b/Documentation/git-p4.txt
> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::
> git config git-p4.largeFileSystem GitLFS
> -------------
> +
> - [1] https://git-lfs.github.com/
> +[1] https://git-lfs.github.com/
>
> git-p4.largeFileExtensions::
> All files matching a file extension in the list will be processed
> --
> 2.5.1
>
Is there any chance to get this in? The formatting error is quite obvious here:
https://git-scm.com/docs/git-p4
(while looking at this website I also noticed wrong double quotes around cp1252
which I will fix with a subsequent patch)
Thanks,
Lars
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] git-p4: fix AsciiDoc formatting
2016-03-13 17:46 ` Lars Schneider
@ 2016-03-14 3:51 ` Junio C Hamano
2016-03-15 8:38 ` Luke Diamand
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2016-03-14 3:51 UTC (permalink / raw
To: Lars Schneider; +Cc: git, sunshine
Lars Schneider <larsxschneider@gmail.com> writes:
>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
>> index 738cfde..140fc12 100644
>> --- a/Documentation/git-p4.txt
>> +++ b/Documentation/git-p4.txt
>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::
>> git config git-p4.largeFileSystem GitLFS
>> -------------
>> +
>> - [1] https://git-lfs.github.com/
>> +[1] https://git-lfs.github.com/
>>
>> git-p4.largeFileExtensions::
>> All files matching a file extension in the list will be processed
>> --
>> 2.5.1
>>
>
> Is there any chance to get this in? The formatting error is quite obvious here:
> https://git-scm.com/docs/git-p4
>
> (while looking at this website I also noticed wrong double quotes around cp1252
> which I will fix with a subsequent patch)
I ignored this when I saw it first, primarily because I assumed that
anything related to git-p4 would get a review by somebody better
versed with git-p4 before I get to it; I forgot about the patch
after it was buried in the other messages without anything
happening.
Will take a look.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] git-p4: fix AsciiDoc formatting
2016-03-14 3:51 ` Junio C Hamano
@ 2016-03-15 8:38 ` Luke Diamand
2016-03-15 9:09 ` Lars Schneider
0 siblings, 1 reply; 5+ messages in thread
From: Luke Diamand @ 2016-03-15 8:38 UTC (permalink / raw
To: Junio C Hamano; +Cc: Lars Schneider, Git Users, Eric Sunshine
On 14 March 2016 at 03:51, Junio C Hamano <gitster@pobox.com> wrote:
> Lars Schneider <larsxschneider@gmail.com> writes:
>
>>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
>>> index 738cfde..140fc12 100644
>>> --- a/Documentation/git-p4.txt
>>> +++ b/Documentation/git-p4.txt
>>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::
>>> git config git-p4.largeFileSystem GitLFS
>>> -------------
>>> +
>>> - [1] https://git-lfs.github.com/
>>> +[1] https://git-lfs.github.com/
>>>
>>> git-p4.largeFileExtensions::
>>> All files matching a file extension in the list will be processed
>>> --
>>> 2.5.1
>>>
>>
>> Is there any chance to get this in? The formatting error is quite obvious here:
>> https://git-scm.com/docs/git-p4
>>
>> (while looking at this website I also noticed wrong double quotes around cp1252
>> which I will fix with a subsequent patch)
>
> I ignored this when I saw it first, primarily because I assumed that
> anything related to git-p4 would get a review by somebody better
> versed with git-p4 before I get to it; I forgot about the patch
> after it was buried in the other messages without anything
> happening.
>
> Will take a look.
Comparing with the git-bisect-lk2009 page, it uses a slightly
different approach for external HTTP references. The references are
put at the end, as internal hyperlinks, and in a bulleted list. It
would make sense to try to be consistent with that, unless there's a
good reason not to.
Luke
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] git-p4: fix AsciiDoc formatting
2016-03-15 8:38 ` Luke Diamand
@ 2016-03-15 9:09 ` Lars Schneider
0 siblings, 0 replies; 5+ messages in thread
From: Lars Schneider @ 2016-03-15 9:09 UTC (permalink / raw
To: Luke Diamand; +Cc: Junio C Hamano, Git Users, Eric Sunshine
> On 15 Mar 2016, at 09:38, Luke Diamand <luke@diamand.org> wrote:
>
> On 14 March 2016 at 03:51, Junio C Hamano <gitster@pobox.com> wrote:
>> Lars Schneider <larsxschneider@gmail.com> writes:
>>
>>>> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
>>>> index 738cfde..140fc12 100644
>>>> --- a/Documentation/git-p4.txt
>>>> +++ b/Documentation/git-p4.txt
>>>> @@ -528,7 +528,7 @@ git-p4.largeFileSystem::
>>>> git config git-p4.largeFileSystem GitLFS
>>>> -------------
>>>> +
>>>> - [1] https://git-lfs.github.com/
>>>> +[1] https://git-lfs.github.com/
>>>>
>>>> git-p4.largeFileExtensions::
>>>> All files matching a file extension in the list will be processed
>>>> --
>>>> 2.5.1
>>>>
>>>
>>> Is there any chance to get this in? The formatting error is quite obvious here:
>>> https://git-scm.com/docs/git-p4
>>>
>>> (while looking at this website I also noticed wrong double quotes around cp1252
>>> which I will fix with a subsequent patch)
>>
>> I ignored this when I saw it first, primarily because I assumed that
>> anything related to git-p4 would get a review by somebody better
>> versed with git-p4 before I get to it; I forgot about the patch
>> after it was buried in the other messages without anything
>> happening.
>>
>> Will take a look.
>
> Comparing with the git-bisect-lk2009 page, it uses a slightly
> different approach for external HTTP references. The references are
> put at the end, as internal hyperlinks, and in a bulleted list. It
> would make sense to try to be consistent with that, unless there's a
> good reason not to.
Right! Thanks for the hint! I will post a reroll soonish.
Thanks,
Lars
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-15 9:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-01 11:05 [PATCH v1] git-p4: fix AsciiDoc formatting larsxschneider
2016-03-13 17:46 ` Lars Schneider
2016-03-14 3:51 ` Junio C Hamano
2016-03-15 8:38 ` Luke Diamand
2016-03-15 9:09 ` Lars Schneider
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).