git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Jeremy Huddleston Sequoia <jeremyhu@freedesktop.org>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: git 2.10.1 test regression in t4014-format-patch.sh
Date: Sun, 09 Oct 2016 17:18:15 -0700	[thread overview]
Message-ID: <F069D0FD-C3CF-4F40-9338-D84E76DB310B@joshtriplett.org> (raw)
In-Reply-To: <3CE95FD5-C5A9-4DE3-8B57-80B858769D1B@freedesktop.org>

On October 9, 2016 5:15:22 PM PDT, Jeremy Huddleston Sequoia <jeremyhu@freedesktop.org> wrote:
>Hey Josh,
>
>Hope you're doing well.
>
>I wanted to let you know that this patch of yours, which landed in git
>2.10.1, introduced some test failures, seen on macOS.
>
>Let me know if you need any additional information to track these down.
>
>Thanks,
>Jeremy
>
>
>not ok 65 - format-patch default signature
>#	
>#		git format-patch --stdout -1 | tail -n 3 >output &&
>#		signature >expect &&
>#		test_cmp expect output
>#	
>
>not ok 132 - format-patch --base
>#	
>#		git checkout side &&
>#		git format-patch --stdout --base=HEAD~3 -1 | tail -n 7 >actual &&
>#		echo >expected &&
>#		echo "base-commit: $(git rev-parse HEAD~3)" >>expected &&
>#		echo "prerequisite-patch-id: $(git show --patch HEAD~2 | git
>patch-id --stable | awk "{print \$1}")" >>expected &&
>#		echo "prerequisite-patch-id: $(git show --patch HEAD~1 | git
>patch-id --stable | awk "{print \$1}")" >>expected &&
>#		signature >> expected &&
>#		test_cmp expected actual
>#	

Can you run the test with the option to show the expected and actual strings?

Did the testsuite run with the wrong git somehow?



  reply	other threads:[~2016-10-10  0:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10  0:15 git 2.10.1 test regression in t4014-format-patch.sh Jeremy Huddleston Sequoia
2016-10-10  0:18 ` Josh Triplett [this message]
2016-10-10  2:55   ` Jeremy Huddleston Sequoia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F069D0FD-C3CF-4F40-9338-D84E76DB310B@joshtriplett.org \
    --to=josh@joshtriplett.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeremyhu@freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).