git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Kevin Ballard <kevin@sb.org>
To: Miles Bader <miles@gnu.org>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: Manual hunk edit mode + emacs + ^G == garbage
Date: Fri, 15 Oct 2010 02:13:55 -0700	[thread overview]
Message-ID: <EDCC7CB3-4DFF-45B8-9E23-E12045CC29D7@sb.org> (raw)
In-Reply-To: <buomxqhayqc.fsf@dhlpc061.dev.necel.com>

On Oct 14, 2010, at 2:51 AM, Miles Bader wrote:

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>> I've been having a rather strange problem using manual hunk edit mode (`git add -p`, e)
>> 
>> Aside from this bug you might want to check out magit.el, it's a much
>> nicer hunk edit more for Emacs than running git add -p in an Emacs
>> terminal is.
> 
> Yup, for that particular problem, magit is, well, like magic :)

I tested out magit, and didn't particularly like it. First off, it seems to be throwing an error when I invoke magit-status, at least if there's no changes. I don't know if this is related to the fact that my emacs is only 22.1, but magit itself doesn't document any required version of emacs. Secondly, when there is a change, the coloration is really hard to read, and the navigation is quite poor as well (and I didn't find anything to make it better in the cheatsheet). And it's far slower than just using `git add -p` and only dropping into emacs occasionally for manual hunk edits.

I'm still very much interested in finding a solution to why ^G kills emacs when it's invoked by git. As I said earlier, it appears that emacs shares the same process group with the perl process that called it, even though Andreas Schwab says it puts itself into its own process group and invoking emacs from the shell does just that. Does anyone know why this might be happening?

-Kevin Ballard

  reply	other threads:[~2010-10-15  9:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-13 21:37 Manual hunk edit mode + emacs + ^G == garbage Kevin Ballard
2010-10-13 21:48 ` Drew Northup
2010-10-13 21:53   ` Kevin Ballard
2010-10-13 22:40     ` Andreas Schwab
2010-10-13 22:49       ` Kevin Ballard
2010-10-14  9:37 ` Ævar Arnfjörð Bjarmason
2010-10-14  9:47   ` Kevin Ballard
2010-10-14  9:51   ` Miles Bader
2010-10-15  9:13     ` Kevin Ballard [this message]
2012-02-22 21:43       ` Matt McClure

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EDCC7CB3-4DFF-45B8-9E23-E12045CC29D7@sb.org \
    --to=kevin@sb.org \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).