* [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings
@ 2018-01-14 16:45 randall.s.becker
2018-01-14 17:25 ` Philip Oakley
0 siblings, 1 reply; 3+ messages in thread
From: randall.s.becker @ 2018-01-14 16:45 UTC (permalink / raw)
To: git; +Cc: Randall S. Becker
From: "Randall S. Becker" <rsbecker@nexbridge.com>
* The while loop in the inline method hashmap_enable_item_counting
used an unneeded variable. The loop has been revised accordingly.
Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
---
hashmap.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hashmap.h b/hashmap.h
index 7ce79f3..d375d9c 100644
--- a/hashmap.h
+++ b/hashmap.h
@@ -400,7 +400,6 @@ static inline void hashmap_disable_item_counting(struct hashmap *map)
*/
static inline void hashmap_enable_item_counting(struct hashmap *map)
{
- void *item;
unsigned int n = 0;
struct hashmap_iter iter;
@@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct hashmap *map)
return;
hashmap_iter_init(map, &iter);
- while ((item = hashmap_iter_next(&iter)))
+ while (hashmap_iter_next(&iter))
n++;
map->do_count_items = 1;
--
2.8.5.23.g6fa7ec3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings
2018-01-14 16:45 [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings randall.s.becker
@ 2018-01-14 17:25 ` Philip Oakley
2018-01-14 18:20 ` Randall S. Becker
0 siblings, 1 reply; 3+ messages in thread
From: Philip Oakley @ 2018-01-14 17:25 UTC (permalink / raw)
To: randall.s.becker, git; +Cc: Randall S. Becker
From: <randall.s.becker@rogers.com>
Subject: [PATCH] Remoted unnecessary void* from hashmap.h that caused
compile warnings
s/Remoted/Removed/ ?
Maybe shorten to " hashmap.h: remove unnecessary void* " (ex the superflous
spaces)
--
Philip
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> * The while loop in the inline method hashmap_enable_item_counting
> used an unneeded variable. The loop has been revised accordingly.
>
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
> hashmap.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hashmap.h b/hashmap.h
> index 7ce79f3..d375d9c 100644
> --- a/hashmap.h
> +++ b/hashmap.h
> @@ -400,7 +400,6 @@ static inline void
> hashmap_disable_item_counting(struct hashmap *map)
> */
> static inline void hashmap_enable_item_counting(struct hashmap *map)
> {
> - void *item;
> unsigned int n = 0;
> struct hashmap_iter iter;
>
> @@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct
> hashmap *map)
> return;
>
> hashmap_iter_init(map, &iter);
> - while ((item = hashmap_iter_next(&iter)))
> + while (hashmap_iter_next(&iter))
> n++;
>
> map->do_count_items = 1;
> --
> 2.8.5.23.g6fa7ec3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings
2018-01-14 17:25 ` Philip Oakley
@ 2018-01-14 18:20 ` Randall S. Becker
0 siblings, 0 replies; 3+ messages in thread
From: Randall S. Becker @ 2018-01-14 18:20 UTC (permalink / raw)
To: 'Philip Oakley', git
On January 14, 2018 12:25 PM, Philip Oakley wrote:
> To: randall.s.becker@rogers.com; git@vger.kernel.org
> Cc: Randall S. Becker <rsbecker@nexbridge.com>
> Subject: Re: [PATCH] Remoted unnecessary void* from hashmap.h that
> caused compile warnings
>
> From: <randall.s.becker@rogers.com>
> Subject: [PATCH] Remoted unnecessary void* from hashmap.h that caused
> compile warnings
>
> s/Remoted/Removed/ ?
>
> Maybe shorten to " hashmap.h: remove unnecessary void* " (ex the
> superflous
> spaces)
I amended the commit fixing the typo and cleaning up the comment.
Thanks,
Randall
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-14 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-14 16:45 [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings randall.s.becker
2018-01-14 17:25 ` Philip Oakley
2018-01-14 18:20 ` Randall S. Becker
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).