From: "Philip Oakley" <philipoakley@iee.org>
To: <randall.s.becker@rogers.com>, <git@vger.kernel.org>
Cc: "Randall S. Becker" <rsbecker@nexbridge.com>
Subject: Re: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings
Date: Sun, 14 Jan 2018 17:25:15 -0000 [thread overview]
Message-ID: <E2F9FAE97F7D4B49A5A644FC796A9AAC@PhilipOakley> (raw)
In-Reply-To: 20180114164529.10120-1-randall.s.becker@rogers.com
From: <randall.s.becker@rogers.com>
Subject: [PATCH] Remoted unnecessary void* from hashmap.h that caused
compile warnings
s/Remoted/Removed/ ?
Maybe shorten to " hashmap.h: remove unnecessary void* " (ex the superflous
spaces)
--
Philip
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> * The while loop in the inline method hashmap_enable_item_counting
> used an unneeded variable. The loop has been revised accordingly.
>
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
> hashmap.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hashmap.h b/hashmap.h
> index 7ce79f3..d375d9c 100644
> --- a/hashmap.h
> +++ b/hashmap.h
> @@ -400,7 +400,6 @@ static inline void
> hashmap_disable_item_counting(struct hashmap *map)
> */
> static inline void hashmap_enable_item_counting(struct hashmap *map)
> {
> - void *item;
> unsigned int n = 0;
> struct hashmap_iter iter;
>
> @@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct
> hashmap *map)
> return;
>
> hashmap_iter_init(map, &iter);
> - while ((item = hashmap_iter_next(&iter)))
> + while (hashmap_iter_next(&iter))
> n++;
>
> map->do_count_items = 1;
> --
> 2.8.5.23.g6fa7ec3
>
next prev parent reply other threads:[~2018-01-14 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 16:45 [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings randall.s.becker
2018-01-14 17:25 ` Philip Oakley [this message]
2018-01-14 18:20 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E2F9FAE97F7D4B49A5A644FC796A9AAC@PhilipOakley \
--to=philipoakley@iee.org \
--cc=git@vger.kernel.org \
--cc=randall.s.becker@rogers.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).