git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Raitanen, Adam" <araitane@ciena.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Possible bug in Makefile when executing curl-config
Date: Mon, 22 Jul 2019 19:46:37 +0000	[thread overview]
Message-ID: <DM6PR04MB47939645A97D099241AD25F0D0C40@DM6PR04MB4793.namprd04.prod.outlook.com> (raw)

I believe there may be a bug in the Makefile introduced by the following commit:

https://github.com/git/git/commit/23c4bbe28e61974577164db09cbd1d1c7e568ca4

The commit was merged in 2.20.0:

* The way -lcurl library gets linked has been simplified by taking
   advantage of the fact that we can just ask curl-config command how.

Unfortunately it assumes that curl-config is in the path which is not always the case. When using "--with-curl=/path/to/curl" in the configure command, the path to the actual curl-config executable is ignored and the build fails around here:

    CC http-fetch.o
make: curl-config: Command not found
    LINK git-http-fetch
http.o: In function `fill_active_slots':
/tmp/git-2.21.0/http.c:1385: undefined reference to `curl_easy_cleanup'
.

We were able to workaround this by forcing the correct path into the make env:

make CURL_LDFLAGS="$(/path/to/curl/curl-config --libs)".

I reproduced the problem in the latest version 2.22.0.

Thanks,
Adam


             reply	other threads:[~2019-07-22 20:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 19:46 Raitanen, Adam [this message]
2019-07-22 21:12 ` Possible bug in Makefile when executing curl-config Jeff King
2019-07-23 19:43   ` [**EXTERNAL**] " Raitanen, Adam
2019-07-23 20:16     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR04MB47939645A97D099241AD25F0D0C40@DM6PR04MB4793.namprd04.prod.outlook.com \
    --to=araitane@ciena.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).