git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ben Peart <Ben.Peart@microsoft.com>
To: Luke Diamand <luke@diamand.org>, Git Users <git@vger.kernel.org>
Cc: Alex Vandiver <alexmv@dropbox.com>
Subject: RE: git-p4 + watchman - watching the p4 repo?
Date: Mon, 8 Jan 2018 17:42:06 +0000	[thread overview]
Message-ID: <DM5PR2101MB0902FE564628A5604AB860F9F4130@DM5PR2101MB0902.namprd21.prod.outlook.com> (raw)
In-Reply-To: <CAE5ih79t8N969E-8qm9JMNZZo6qvRqw6GA=b6UTHskB-ozt7Fg@mail.gmail.com>

I haven't used perforce so am unfamiliar with any behaviors specific to that but the logic to have git automatically tell watchman to start watching repos is just a convenience feature.  Feel free to remove/disable/modify it in the fsmonitor-watchman integration script:

	if ($retry > 0 and $o->{error} and $o->{error} =~ m/unable to resolve root .* directory (.*) is not watched/) {
		print STDERR "Adding '$git_work_tree' to watchman's watch list.\n";
		$retry--;
		qx/watchman watch "$git_work_tree"/;

Ben

> -----Original Message-----
> From: Luke Diamand [mailto:luke@diamand.org]
> Sent: Monday, January 8, 2018 12:15 PM
> To: Git Users <git@vger.kernel.org>
> Cc: Alex Vandiver <alexmv@dropbox.com>; Ben Peart
> <Ben.Peart@microsoft.com>
> Subject: git-p4 + watchman - watching the p4 repo?
> 
> Hi!
> 
> I could be wrong about this, but I when I tried mixing watchman with git-p4, I
> found that on "git p4 submit" it ended up watching the p4 repo, which seems
> a bit pointless (and was also very slow).
> 
> $ [create git-p4 clone of some p4 repo]
> $ : >bar
> $ git add bar && git commit -m 'adding bar'
> $ git p4 submit --origin HEAD^ --shelve
> Perforce checkout for depot path //depot/ located at /tmp/p4/cli/
> Synchronizing p4 checkout...
> ... - file(s) up-to-date.
> Applying 4ce4057 change
> //depot/bar#1 - opened for edit
> Adding '/tmp/p4/cli' to watchman's watch list.
> 
> Is there any way to stop it doing this?
> 
> Thanks!
> Luke

      reply	other threads:[~2018-01-08 17:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08 17:15 git-p4 + watchman - watching the p4 repo? Luke Diamand
2018-01-08 17:42 ` Ben Peart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR2101MB0902FE564628A5604AB860F9F4130@DM5PR2101MB0902.namprd21.prod.outlook.com \
    --to=ben.peart@microsoft.com \
    --cc=alexmv@dropbox.com \
    --cc=git@vger.kernel.org \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).