From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [IPv6:2604:1380:45e3:2400::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 801E71F44D for ; Wed, 10 Apr 2024 09:20:23 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=archibald.dev header.i=@archibald.dev header.a=rsa-sha256 header.s=protonmail3 header.b=DokehW/K; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2E38328925A for ; Wed, 10 Apr 2024 09:20:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E0CC1159593; Wed, 10 Apr 2024 09:16:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=archibald.dev header.i=@archibald.dev header.b="DokehW/K" Received: from mail-4022.proton.ch (mail-4022.proton.ch [185.70.40.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F39C155732 for ; Wed, 10 Apr 2024 09:16:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.40.22 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712740604; cv=none; b=NVdlhQGm6cbYuTXpfGgtds9mJdmKv1vufVWEFBZnuiqhVSx8JoA0s95OaCjXevBvMM59N3AVFJZFBk6e7kEOTgun8ag3edL8bQTGZ0/pDg6SCuCtuEVlXPCUapCQ6OohBHoqOkT+JbOziSuYoOWzzSs/7YPya+Mkx2c3V6BIM0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712740604; c=relaxed/simple; bh=9AtqVPiqGCd0xUV1c5T1LFFz72Ij603I1uqQVlJnTq4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bL1Otf51dXuViW4xSCOCijkO38P103Ji9o6t18WTczjc891YxTIeNomxVZP5WmJf2uDEHj6hBIUmq5TXMpARhz4WhjTl2mwjznknkE3sulgog2hBqEM4mn4DBKPNQCgyusywT4zrGbWTTUYjIv7Ww+vnZMlcAK+9KqmRVLbGkV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=archibald.dev; spf=pass smtp.mailfrom=archibald.dev; dkim=pass (2048-bit key) header.d=archibald.dev header.i=@archibald.dev header.b=DokehW/K; arc=none smtp.client-ip=185.70.40.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=archibald.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=archibald.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=archibald.dev; s=protonmail3; t=1712740595; x=1712999795; bh=9AtqVPiqGCd0xUV1c5T1LFFz72Ij603I1uqQVlJnTq4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=DokehW/KXrU5rlL/6GHNbA+L0Co5suvMCWkjfjeBuCr6XBk96aETghV1e+gLCJt43 FNfyPPTm4qBeTIxiWltlIt3PAoQBIHPwa52CDjkV61q3XEY5AwvM5Gd5tA0we+q5M0 HMCF71vaLdOXMsUwrzIfjj0ps1ifpgmpPWD3T4CrhSps//TQj8pKxxqmv9OlU74KZM hQIBZ1cA31fe4/baR1dEW8dU4keht+t6LBlBh6i1YDV+C8r249QyWL7D5kTkXnCXDZ v4/PFKwyEjkuiwpkDnFYdgllTi01wx+Ic2rqguuVJJhlbXwvlWO6Qepkzy4bW9zWPX eitCT/ft256cA== Date: Wed, 10 Apr 2024 09:16:24 +0000 To: Chris Torek From: Thalia Archibald Cc: Patrick Steinhardt , git@vger.kernel.org, Elijah Newren Subject: Re: [PATCH v2 1/8] fast-import: tighten path unquoting Message-ID: In-Reply-To: References: <20240322000304.76810-1-thalia@archibald.dev> <784B5318-F155-4D93-8085-62ACA63432E5@archibald.dev> Feedback-ID: 63908566:user:proton Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Apr 10, 2024, at 02:14, Thalia Archibald wrote: > On Apr 10, 2024, at 01:51, Chris Torek wrote: >> On Wed, Apr 10, 2024 at 1:47=E2=80=AFAM Thalia Archibald wrote: >>> strchrnul does what I want here and I=E2=80=99ve replaced it with that. >>=20 >> `strchrnul` is a GNU extension (found on a lot of systems, but not >> part of C90 or C99). >=20 > I can=E2=80=99t speak to Git standards, but it seems broadly used in Git,= including > three times already in fast-import. =E2=80=A6 and that would be because it is supplied when unavailable: git-compat-util.h #ifndef HAVE_STRCHRNUL #define strchrnul gitstrchrnul static inline char *gitstrchrnul(const char *s, int c) { =09while (*s && *s !=3D c) =09=09s++; =09return (char *)s; } #endif Thalia