From: "signal@dynax.at" <signal@dynax.at>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: making use of $sm_path @ git submodule foreach —recursive
Date: Mon, 28 Nov 2022 15:18:57 +0100 [thread overview]
Message-ID: <DEE63B3B-95B2-469B-AC02-CAC1B5FCAC67@dynax.at> (raw)
In-Reply-To: <221128.86r0xnkzyw.gmgdl@evledraar.gmail.com>
Oh, thanks! I didn’t notice that it chdir’ed into the submodule folder! Then clearly this is the relation I was looking for!
Thanks! sorry for the noise!
> On 28.11.2022, at 13:43, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>
>
> On Sun, Nov 27 2022, signal@dynax.at wrote:
>
>> Hi,
>>
>> when using
>> git submodule foreach —recursive [..]
>> $sm_path contains only the relative part of the latest
>> recursion. Since the command has no generic way of knowing from which
>> recursion level it is executed any $sm_path of deeper recursion level
>> is useless unless there is a way for the command to find out from
>> which recursion it is called.
>>
>> I suggest $sm_path should be extended to be relative to the repo from where the submodule recursion started or another variable should contain the recursive part.
>>
>> Viele Grüße/Cheers,
>> Hagen.
>
> I think it might be sensible to have a $super_prefix_sm_path or
> something which does what you suggest here.
>
> But the current "$sm_path" is far from useless, it's just not useful for
> what you're trying to do.
>
> When we run a command in sub1/sub2 or whatever the "$sm_path" will be
> "sub1", then as we cd to "sub1" it'll be "sub2".
>
> You want "sub1/sub2" there, but a "sub2" is still useful, because we've
> chdir()'d to the "sub1" at that point.
>
> So you can e.g. run 'git -C "$sm_path" log' in your 'foreach', or
> another command that expects to get the *relative* submodule path.
>
> If we simply changed how "$sm_path" works that would break, and if we
> "fixed" that by not chdir()-ing from the super-project we'd break even
> more things, as e.g.:
>
> git submodule foreach 'git pull'
>
> Or whatever wouldn't behave as you'd expect.
prev parent reply other threads:[~2022-11-28 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 22:53 making use of $sm_path @ git submodule foreach —recursive signal
2022-11-28 12:43 ` Ævar Arnfjörð Bjarmason
2022-11-28 14:18 ` signal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEE63B3B-95B2-469B-AC02-CAC1B5FCAC67@dynax.at \
--to=signal@dynax.at \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).