From: "Gumbel, Matthew K" <matthew.k.gumbel@intel.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: [PATCH] commit: Optimize number of lstat() calls
Date: Fri, 3 Feb 2017 23:22:30 +0000 [thread overview]
Message-ID: <DA0A42D68346B1469147552440A645039A9C9988@ORSMSX115.amr.corp.intel.com> (raw)
When making a --only commit, original behavior was to do a full cache
update for the purposes of giving the pre-commit hook an up-to-date set
of stat data. That would result in long runtime for git-commit in a big
repo on NFS (>60s for a 54k-file repo).
With this change, when doing a --only commit and no pre-commit hook is
present, the cache update is skipped since it is known a priori which
files are to be committed.
This was discussed on the mailing list here:
https://public-inbox.org/git/DA0A42D68346B1469147552440A645039A9C56D4@ORSMSX115.amr.corp.intel.com/
Signed-off-by: Matthew K. Gumbel <matthew.k.gumbel@intel.com>
---
builtin/commit.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 2de5f6c..1df3d71 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -470,7 +470,9 @@ static const char *prepare_index(int argc, const char **argv, const char *prefix
hold_locked_index(&index_lock, LOCK_DIE_ON_ERROR);
add_remove_files(&partial);
- refresh_cache(REFRESH_QUIET);
+ if (find_hook("pre-commit")) {
+ refresh_cache(REFRESH_QUIET);
+ }
update_main_cache_tree(WRITE_TREE_SILENT);
if (write_locked_index(&the_index, &index_lock, CLOSE_LOCK))
die(_("unable to write new_index file"));
@@ -482,7 +484,9 @@ static const char *prepare_index(int argc, const char **argv, const char *prefix
create_base_index(current_head);
add_remove_files(&partial);
- refresh_cache(REFRESH_QUIET);
+ if (find_hook("pre-commit")) {
+ refresh_cache(REFRESH_QUIET);
+ }
if (write_locked_index(&the_index, &false_lock, CLOSE_LOCK))
die(_("unable to write temporary index file"));
--
2.8.4
next reply other threads:[~2017-02-03 23:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 23:22 Gumbel, Matthew K [this message]
2017-02-03 23:38 ` [PATCH] commit: Optimize number of lstat() calls Junio C Hamano
2017-02-04 6:50 ` Junio C Hamano
2017-02-04 0:35 ` Johannes Schindelin
2017-02-04 7:23 ` Junio C Hamano
2017-02-04 10:42 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA0A42D68346B1469147552440A645039A9C9988@ORSMSX115.amr.corp.intel.com \
--to=matthew.k.gumbel@intel.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).