From: Lars Schneider <larsxschneider@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Jeff King <peff@peff.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job
Date: Sat, 17 Mar 2018 15:29:31 +0100 [thread overview]
Message-ID: <D8137CD9-9E11-4FBC-B89B-907C007FC6E9@gmail.com> (raw)
In-Reply-To: <CACsJy8A3_itjs0MRar+Aog=0yZDuAK2-x4MU=Rvqh2C6Le-7Aw@mail.gmail.com>
> On 17 Mar 2018, at 09:01, Duy Nguyen <pclouds@gmail.com> wrote:
>
> On Fri, Mar 16, 2018 at 10:22 PM, Jeff King <peff@peff.net> wrote:
>>> diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
>>> index 3735ce413f..f6f346c468 100755
>>> --- a/ci/run-build-and-tests.sh
>>> +++ b/ci/run-build-and-tests.sh
>>> @@ -7,6 +7,22 @@
>>>
>>> ln -s "$cache_dir/.prove" t/.prove
>>>
>>> +if [ "$jobname" = linux-gcc ]; then
>>> + gcc-6 --version
>>> + cat >config.mak <<-EOF
>>> + CC=gcc-6
>>> + CFLAGS = -g -O2 -Wall
>>> + CFLAGS += -Wextra
>>> + CFLAGS += -Wmissing-prototypes
>>> + CFLAGS += -Wno-empty-body
>>> + CFLAGS += -Wno-maybe-uninitialized
>>> + CFLAGS += -Wno-missing-field-initializers
>>> + CFLAGS += -Wno-sign-compare
>>> + CFLAGS += -Wno-unused-function
>>> + CFLAGS += -Wno-unused-parameter
>>> + EOF
>>> +fi
>>
>> Why isn't this just turning on DEVELOPER=1 if we know we have a capable
>> compiler?
>
> DEVELOPER=1 is always set even before this patch. It's set and
> exported in lib-travisci.sh.
I interpreted Peff's comment like this:
If DEVELOPER=1 is set and we detect a gcc-6 in the makefile,
then we could set your additional flags in the makefile.
This way every developer with a new compiler would run these
flags locally (if DEVELOPER=1 is set).
- Lars
next prev parent reply other threads:[~2018-03-17 14:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 1:46 [PATCH] travis-ci: enable more warnings on travis linux-gcc job Nguyễn Thái Ngọc Duy
2018-03-16 19:33 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2018-03-16 21:22 ` Jeff King
2018-03-17 8:01 ` Duy Nguyen
2018-03-17 14:29 ` Lars Schneider [this message]
2018-03-17 14:59 ` Duy Nguyen
2018-03-17 16:08 ` Jeff King
2018-03-17 16:12 ` Jeff King
2018-03-17 23:50 ` Junio C Hamano
2018-03-18 8:18 ` [PATCH] Makefile: detect compiler and enable more warnings in DEVELOPER=1 Nguyễn Thái Ngọc Duy
2018-03-18 9:06 ` Eric Sunshine
2018-03-18 9:17 ` Duy Nguyen
2018-03-18 9:20 ` Jeff King
2018-03-18 9:24 ` Eric Sunshine
2018-03-18 9:28 ` Jeff King
2018-03-18 9:37 ` Eric Sunshine
2018-03-18 9:26 ` Jeff King
2018-03-18 9:45 ` Duy Nguyen
2018-03-18 15:55 ` Duy Nguyen
2018-03-18 18:56 ` Ramsay Jones
2018-03-19 16:30 ` Duy Nguyen
2018-03-20 5:32 ` Jeff King
2018-03-24 12:53 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2018-03-25 0:40 ` Eric Sunshine
2018-03-26 22:02 ` Junio C Hamano
2018-03-27 15:03 ` Duy Nguyen
2018-03-27 16:52 ` Junio C Hamano
2018-03-29 15:03 ` [PATCH v3 0/3] Enable more compiler warnings for devs Nguyễn Thái Ngọc Duy
2018-03-29 15:03 ` [PATCH v3 1/3] connect.c: mark die_initial_contact() NORETURN Nguyễn Thái Ngọc Duy
2018-03-29 15:03 ` [PATCH v3 2/3] Makefile: detect compiler and enable more warnings in DEVELOPER=1 Nguyễn Thái Ngọc Duy
2018-03-29 15:03 ` [PATCH v3 3/3] Makefile: add EAGER_DEVELOPER mode Nguyễn Thái Ngọc Duy
2018-03-31 16:40 ` [PATCH 4/3] Makefile: untangle DEVELOPER and -Werror Ævar Arnfjörð Bjarmason
2018-03-31 18:36 ` Duy Nguyen
2018-04-03 9:19 ` Ævar Arnfjörð Bjarmason
2018-04-03 15:17 ` Duy Nguyen
2018-04-06 21:42 ` Jeff King
2018-04-07 9:52 ` Duy Nguyen
2018-04-07 12:36 ` Ævar Arnfjörð Bjarmason
2018-04-07 17:03 ` Duy Nguyen
2018-04-07 18:38 ` Ævar Arnfjörð Bjarmason
2018-04-14 19:19 ` [PATCH v4 0/4] Make DEVELOPER more more flexible with DEVOPTS Ævar Arnfjörð Bjarmason
2018-04-16 4:57 ` Junio C Hamano
2018-04-14 19:19 ` [PATCH v4 1/4] connect.c: mark die_initial_contact() NORETURN Ævar Arnfjörð Bjarmason
2018-04-14 19:19 ` [PATCH v4 2/4] Makefile: detect compiler and enable more warnings in DEVELOPER=1 Ævar Arnfjörð Bjarmason
2018-04-14 19:19 ` [PATCH v4 3/4] Makefile: add a DEVOPTS to suppress -Werror under DEVELOPER Ævar Arnfjörð Bjarmason
2018-04-14 19:19 ` [PATCH v4 4/4] Makefile: add a DEVOPTS to get all of -Wextra Ævar Arnfjörð Bjarmason
2018-03-17 15:16 ` [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8137CD9-9E11-4FBC-B89B-907C007FC6E9@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).