git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Luca Milanesio <luca.milanesio@gmail.com>
To: Phil Hord <phil.hord@gmail.com>
Cc: Repo Discussion <repo-discuss@googlegroups.com>,
	Git <git@vger.kernel.org>, Heiko Voigt <hvoigt@hvoigt.net>,
	Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: Submodules as first class citizens (was Re: Moving to subtrees for plugins?)
Date: Sat, 6 Jun 2015 20:53:37 +0100	[thread overview]
Message-ID: <D2BB8369-E552-4AC3-967E-8F963206E03C@gmail.com> (raw)
In-Reply-To: <CABURp0og9i9S3_ZWf5Ce9LT785QJo4H-TVtFaKUTXr2N7FB+ew@mail.gmail.com>

Thank you Phil, you anticipated me :-)

Luca.

> On 6 Jun 2015, at 18:49, Phil Hord <phil.hord@gmail.com> wrote:
> 
> On Fri, Jun 5, 2015, 2:58 AM lucamilanesio <luca.milanesio@gmail.com> wrote:
>>> 
>>> Some devs of my Team complained that with submodules it is
>>> difficult to see the “full picture” of the difference
>>> between two SHA1 on the root project, as the submodules
>>> would just show as different SHA1s. When you Google
>>> “subtree submodules” you find other opinions as well:
>>> 
>>> Just to mention a few:
>>> -
>>> https://codingkilledthecat.wordpress.com/2012/04/28/why-y
>>> our-company-shouldnt-use-git-submodules/ -
>>> http://blogs.atlassian.com/2013/05/alternatives-to-git-su
>>> bmodule-git-subtree/
>>> 
>>> To be honest with you, I am absolutely fine with
>>> submodules as I can easily leave with the “extra pain” of
>>> diffing by hand recursively on submodules. But it is true
>>> that it may happen to either forget to do a git submodule
>>> update or otherwise forget you are in a detached branch
>>> and start committing “on the air” without a branch.
> 
> ...
> 
>> Ideally, as a "git clone --recursive" already exists, I would like to
>> see a "git diff --recursive" that goes through the submodules as well :-)
>> 
>> Something possibly to propose to the Git mailing list?
> 
> 
> I've worked on git diff --recursive a bit myself, along with some
> simpler use cases (git ls-tree --recursive) as POCs. I think some of
> the needs there begin to have ui implications which could be
> high-friction. I really want to finish it someday, but I've been too
> busy lately at $job, and now my experiments are all rather stale.
> 
> It would be a good discussion to have over at the git list (copied).
> Heiko and Jens have laid some new groundwork in this area and it may
> be a good time to revisit it.  Or maybe they've even moved deeper than
> that; I have been distracted for well over a year now.
> 
> Phil

  reply	other threads:[~2015-06-06 19:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-06 17:49 Submodules as first class citizens (was Re: Moving to subtrees for plugins?) Phil Hord
2015-06-06 19:53 ` Luca Milanesio [this message]
2015-06-07  6:26   ` Stefan Beller
2015-06-09 18:40     ` Jens Lehmann
2015-06-11 16:11       ` Phil Hord
2015-06-11 18:56         ` Jens Lehmann
2015-06-15  9:03       ` Heiko Voigt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2BB8369-E552-4AC3-967E-8F963206E03C@gmail.com \
    --to=luca.milanesio@gmail.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=hvoigt@hvoigt.net \
    --cc=phil.hord@gmail.com \
    --cc=repo-discuss@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).