From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 147.75.80.0/22 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [147.75.80.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9FC771F44D for ; Sun, 5 May 2024 23:17:44 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=jamesliu.io header.i=@jamesliu.io header.a=rsa-sha256 header.s=fm3 header.b=kaaI5Zfi; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=afkM+q4d; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3DCD41F21880 for ; Sun, 5 May 2024 23:17:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5419414037E; Sun, 5 May 2024 23:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jamesliu.io header.i=@jamesliu.io header.b="kaaI5Zfi"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="afkM+q4d" Received: from wfout4-smtp.messagingengine.com (wfout4-smtp.messagingengine.com [64.147.123.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A6D4374CB for ; Sun, 5 May 2024 23:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714951050; cv=none; b=p6wN6ks1cyRrr+OsIqJ6TkTDA4yAKUwLHtol22fdRKB0T8un4sfaTXWyWMu8PbswuJY8GSi94/cGUb8J+8vzHrmPFh/l1GJlBt/zKhzKF8ynQIfPYUvLodIs7Lpe5gx1mjomn3szbsZvo01GKL44uY6QLPiB+YrfIOcddw/hZOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714951050; c=relaxed/simple; bh=5zwSWI6bXh/uCqGIt8Q67wDsh2s+Aebu9FcBmdis51E=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To: References:In-Reply-To; b=iNHwIVmHwict5GAViSTECKDYl7+sITM6bTKMzGQa39hBvuwEDOUCvfHUcTYF2Ag8WaLq+xP2rIaMFrqqzNGyoFROpPb1gnf/np1jnZuvIW03GqyE/2FNq0QiMsi/1iHvHPN4R9DI8FzMdM98q39eRyXMkdHcwQmDe2Rsjsh0kXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=jamesliu.io; spf=pass smtp.mailfrom=jamesliu.io; dkim=pass (2048-bit key) header.d=jamesliu.io header.i=@jamesliu.io header.b=kaaI5Zfi; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=afkM+q4d; arc=none smtp.client-ip=64.147.123.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=jamesliu.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jamesliu.io Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.west.internal (Postfix) with ESMTP id 9223B1C0012C; Sun, 5 May 2024 19:17:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 05 May 2024 19:17:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jamesliu.io; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1714951046; x=1715037446; bh=BDSB+LBES9IbTKFKawAzts3boXtkDqtNM++wK5BFKwM=; b= kaaI5Zfi1v60RzWrH4X7y5cQCey3ra4lQ7mlhCE8EFs3mQEy+tgLYWjxIKSK7vWk QJiyTShqYFl+2Vcj1dplqR5FxnrIBS4bmuUpS4HuOZg9EpoglAjDJdFqGU+dZLEl ji8ue9/iYDemph2PdpQvE5iL4YRjMwW/xNsgVEUaaK6ebQCKs5LMh5XYk7BZp4Ms KVFuSz+EmM4uHl+hza5MZFNPkze+i57okwzCWwmNxvEaKPVV79UKxk9/0XgMDspz WgPhbKYsIk4fQ275CUhkvV+umxUIOntenHTg8kuCF99WhAX/PYhdhIanI0rmPghk EDB9C3bcBLvK24+zXxmRzA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714951046; x= 1715037446; bh=BDSB+LBES9IbTKFKawAzts3boXtkDqtNM++wK5BFKwM=; b=a fkM+q4dOwnghB6pc2LMLqNTNR+zXFJhGK2b8enBT0ccWza5x91lsm0zjHR4hTzAf bxWEJ+ePoNRhExe+fZE7wj6mQxBMWJlh7pJTMDxuwgDmV84vNQMpjQikFDO7rccu cAujUwLNbCFVweHjqpu4P0AsHqUkIKdoX6XKN7/hNtl7Fnh2WBsqAGg9Wk7475J0 JhfRcBw4gMffTyeVJqBwfY5ka3v3AWWy5KZ6jLMXb7QYFa6ERUJx712CDsgfJlmv nUsLGRK9rx2x2tTaRb/paqX8mwslOYYhx6PKm1olYeiHFFptWNa3Yl2o514D7rQm 2gJXBAuX5zY5TfX7F0T4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvhedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepggfgtgffkffuhffvofhfjgesthhqredtredtjeenucfhrhhomhepfdflrghm vghsucfnihhufdcuoehjrghmvghssehjrghmvghslhhiuhdrihhoqeenucggtffrrghtth gvrhhnpefhteeuheduleettdejkeduleeuiefhveehuefgheehvdeikeettddvveegieel teenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjrg hmvghssehjrghmvghslhhiuhdrihho X-ME-Proxy: Feedback-ID: i93f149ec:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 May 2024 19:17:24 -0400 (EDT) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 06 May 2024 09:17:21 +1000 Message-Id: Subject: Re: [PATCH v4 0/3] advice: add "all" option to disable all hints From: "James Liu" To: "Karthik Nayak" , X-Mailer: aerc 0.17.0 References: <20240430014724.83813-1-james@jamesliu.io> <20240503071706.78109-1-james@jamesliu.io> In-Reply-To: On Sat May 4, 2024 at 12:35 AM AEST, Karthik Nayak wrote: > Hello James, > > James Liu writes: > > > Hi, > > > > Thank you all for the comprehensive feedback. This is v4 of the patch > > series to introduce a --no-advice option for silencing advice hints. > > > > The main changes are: > > > > - Two preliminary commits to reorder/clean up the options documentation > > and usage string. > > - Caching the value of GIT_ADVICE. > > - Adding tests which explicitly set GIT_ADVICE to false and true. > > > > Cheers, > > James > > > > This version looks good to me. > > Thanks > Karthik > Thanks for the review Karthik! Cheers, James